Skip to content

fix: update launchdarkly-js-sdk-common to 5.8.1#67

Open
kinyoklion wants to merge 3 commits into
mainfrom
devin/1779397175-update-js-sdk-common
Open

fix: update launchdarkly-js-sdk-common to 5.8.1#67
kinyoklion wants to merge 3 commits into
mainfrom
devin/1779397175-update-js-sdk-common

Conversation

@kinyoklion
Copy link
Copy Markdown
Member

@kinyoklion kinyoklion commented May 21, 2026

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

N/A — routine dependency update.

Describe the solution you've provided

Update launchdarkly-js-sdk-common from 5.4.0 to 5.8.1.

Changes required to accommodate event format changes introduced in js-sdk-common 5.5.0+:

  1. Unit test update (LDClient-events-test.js): Custom (track) events now include inline context instead of contextKeys, so updated the assertion accordingly.

  2. Contract test capability updates (contract-tests/index.js):

    • Added inline-context-all: custom events now inline the full context (previously only identify and feature events did)
    • Added client-per-context-summaries: summary events are now emitted per-context via MultiEventSummarizer instead of a single aggregated summary
    • Removed anonymous-redaction: js-sdk-common 5.5.0 removed the redactAnonymous parameter from contextFilter.filter() calls in EventProcessor, so anonymous context attributes are no longer redacted in events

Describe alternatives you've considered

N/A

Additional context

Key behavioral changes in js-sdk-common between 5.4.0 and 5.8.1:

  • 5.5.0: "Inline context in custom events" — custom events use context instead of contextKeys; summary events split per-context; anonymous redaction removed from feature events
  • 5.8.1: Replace uuid dependency with inline implementation

Link to Devin session: https://app.devin.ai/sessions/f3bb526db7cd4ea4a5a41df8a82eaa46
Requested by: @kinyoklion


Note

Medium Risk
Medium risk because it upgrades the shared SDK core and reflects upstream event-schema behavior changes (custom events now inline context, and contract-test capabilities change), which could affect integrations that rely on emitted event payloads.

Overview
Upgrades launchdarkly-js-sdk-common from 5.4.0 to 5.8.1.

Updates event-related expectations to match the newer common SDK: the track() unit test now asserts custom events carry an inline context object (not contextKeys), and the contract-test service advertises new capabilities (inline-context-all, client-per-context-summaries) while dropping anonymous-redaction.

Reviewed by Cursor Bugbot for commit de57213. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

devin-ai-integration Bot and others added 2 commits May 22, 2026 22:11
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
… format changes

Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
@kinyoklion kinyoklion marked this pull request as ready for review May 22, 2026 22:23
@kinyoklion kinyoklion requested a review from a team as a code owner May 22, 2026 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant