fix: update launchdarkly-js-sdk-common to 5.8.1#67
Open
kinyoklion wants to merge 3 commits into
Open
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
… format changes Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
N/A — routine dependency update.
Describe the solution you've provided
Update
launchdarkly-js-sdk-commonfrom5.4.0to5.8.1.Changes required to accommodate event format changes introduced in
js-sdk-common5.5.0+:Unit test update (
LDClient-events-test.js): Custom (track) events now include inlinecontextinstead ofcontextKeys, so updated the assertion accordingly.Contract test capability updates (
contract-tests/index.js):inline-context-all: custom events now inline the full context (previously only identify and feature events did)client-per-context-summaries: summary events are now emitted per-context viaMultiEventSummarizerinstead of a single aggregated summaryanonymous-redaction:js-sdk-common5.5.0 removed theredactAnonymousparameter fromcontextFilter.filter()calls inEventProcessor, so anonymous context attributes are no longer redacted in eventsDescribe alternatives you've considered
N/A
Additional context
Key behavioral changes in
js-sdk-commonbetween 5.4.0 and 5.8.1:contextinstead ofcontextKeys; summary events split per-context; anonymous redaction removed from feature eventsLink to Devin session: https://app.devin.ai/sessions/f3bb526db7cd4ea4a5a41df8a82eaa46
Requested by: @kinyoklion
Note
Medium Risk
Medium risk because it upgrades the shared SDK core and reflects upstream event-schema behavior changes (custom events now inline
context, and contract-test capabilities change), which could affect integrations that rely on emitted event payloads.Overview
Upgrades
launchdarkly-js-sdk-commonfrom5.4.0to5.8.1.Updates event-related expectations to match the newer common SDK: the
track()unit test now asserts custom events carry an inlinecontextobject (notcontextKeys), and the contract-test service advertises new capabilities (inline-context-all,client-per-context-summaries) while droppinganonymous-redaction.Reviewed by Cursor Bugbot for commit de57213. Bugbot is set up for automated code reviews on this repo. Configure here.