Skip to content

chore: scope v4 branch workflows to v4 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaron-zeisler merged 2 commits into from
May 27, 2026
+5 −5
Merged

chore: scope v4 branch workflows to v4 #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3c7249
[SDK-2119] chore: scope v4 branch workflows to v4 (cross-maintain Go …
aaron-zeisler May 26, 2026
d49d3d2
[SDK-2119] chore: hardcode release-please target-branch to v4
aaron-zeisler May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check-go-versions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
branch: ["v3"]
branch: ["v3", "v4"]
fail-fast: false
env:
officialLatestVersion: ${{ needs.check-go-eol.outputs.latest }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Build and Test
on:
push:
branches: [ 'v3', 'feat/**' ]
branches: [ 'v4', 'feat/**' ]
Copy link
Copy Markdown

@cursor cursor Bot May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI workflow drops v3 branch instead of adding v4

High Severity

The push and pull_request branch filters replace v3 with v4 instead of adding v4 alongside v3. This removes CI coverage for the existing v3 branch entirely. The PR description explicitly states the intent is to "add v4 to the branch lists," and check-go-versions.yml correctly uses ["v3", "v4"] — but here v3 is dropped. The branches list needs to include both 'v3' and 'v4'.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit f3c7249. Configure here.

paths-ignore:
- '**.md' # Don't run CI on markdown changes.
pull_request:
branches: [ 'v3', 'feat/**' ]
branches: [ 'v4', 'feat/**' ]
paths-ignore:
- '**.md'

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Run Release Please
on:
push:
branches:
- v3
- v4
Copy link
Copy Markdown

@cursor cursor Bot May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release-please workflow drops v3 branch trigger entirely

High Severity

The push trigger replaces v3 with v4 instead of listing both branches. The PR description says "add v4 to the push trigger… so a single workflow file correctly handles both v3 and v4," and the target-branch: ${{ github.ref_name }} change was specifically designed to support multiple branches dynamically. With only v4 in the trigger, release-please will never fire for v3 pushes.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit f3c7249. Configure here.

Copy link
Copy Markdown
Author

@aaron-zeisler aaron-zeisler May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a per-branch workflow file. It lives on the v4 branch, and on push events GitHub Actions reads the workflow file from the branch being pushed to.

I've updated the PR description to reduce confusion.

workflow_dispatch:

jobs:
Expand All @@ -15,4 +15,4 @@ jobs:
steps:
- uses: googleapis/release-please-action@45996ed1f6d02564a971a2fa1b5860e934307cf7 # v5.0.0
with:
Comment thread
cursor[bot] marked this conversation as resolved.
target-branch: v3
target-branch: v4
Copy link
Copy Markdown

@cursor cursor Bot May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded target-branch contradicts stated dynamic intent

Low Severity

The PR description explicitly states target-branch is set to ${{ github.ref_name }} for robustness, citing the release-please-action#913 auto-detection bug and the hcloud-go pattern as justification. However, the actual code hardcodes target-branch: v4 instead of using the dynamic expression. While functionally equivalent today (the workflow only triggers on v4), this doesn't deliver the stated robustness benefit if additional release branches are added later.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d49d3d2. Configure here.

Copy link
Copy Markdown
Author

@aaron-zeisler aaron-zeisler May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above re: per-branch workflows and updating the PR description.

Loading