chore: add explicit permissions to release-please workflow#37
Merged
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
joker23
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
N/A — this is a CI workflow configuration change only.
Related issues
None.
Describe the solution you've provided
Adds explicit
permissionsto therelease-pleasejob in the GitHub Actions workflow:These permissions are required for the
release-please-actionto:pull-requests: write)contents: write)Without explicit permissions, the job relies on the repository's default
GITHUB_TOKENpermissions, which may be insufficient if the org or repo defaults are set to read-only.Describe alternatives you've considered
Setting these permissions at the workflow level (top-level
permissionskey) was considered, but job-level permissions are preferred to follow the principle of least privilege.Additional context
This is part of an audit of all
launchdarkly-sdk-tagged repositories to ensure release-please workflows have the necessary permissions configured explicitly.Human review checklist
release-please, not a downstream publish/provenance job)Link to Devin session: https://app.devin.ai/sessions/a83b6e4f4fa14b96b859cfb50755a2c1
Requested by: @kinyoklion
Note
Low Risk
Low risk workflow-only change that just scopes
GITHUB_TOKENpermissions forrelease-please; main risk is mis-scoping could prevent release PRs/tags from being created.Overview
Adds explicit job-level
permissionsto.github/workflows/release-please.ymlsorelease-please-actioncan create/update release PRs and publish tags/releases even when repo/org defaultGITHUB_TOKENpermissions are read-only.Written by Cursor Bugbot for commit 35d0afd. This will update automatically on new commits. Configure here.