Skip to content

fix: make Status ToString() methods format consistent #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HarleyRossetto wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: make Status ToString() methods format consistent #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/sdk/server/src/Interfaces/BigSegmentStoreStatus.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ public struct BigSegmentStoreStatus

/// <inheritdoc/>
public override string ToString() =>
string.Format("(Available={0},Stale={1})", Available, Stale);
string.Format("BigSegmentStoreStatus(Available={0},Stale={1})", Available, Stale);
}
}
10 changes: 5 additions & 5 deletions pkgs/sdk/server/src/Interfaces/DataSourceStatus.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public struct DataSourceStatus

/// <inheritdoc/>
public override string ToString() =>
string.Format("DataSourceStatus({0},{1},{2})", State, StateSince, LastError);
string.Format("DataSourceStatus(State={0},StateSince={1},LastError={2})", State, StateSince, LastError);

/// <summary>
/// A description of an error condition that the data source encountered.
Expand Down Expand Up @@ -127,7 +127,7 @@ public override string ToString()
s.Append(Kind.Identifier());
if (StatusCode > 0 || !string.IsNullOrEmpty(Message))
{
s.Append("(");
s.Append('(');
if (StatusCode > 0)
{
s.Append(StatusCode);
Expand All @@ -136,13 +136,13 @@ public override string ToString()
{
if (StatusCode > 0)
{
s.Append(",");
s.Append(',');
}
s.Append(Message);
}
s.Append(")");
s.Append(')');
}
s.Append("@");
s.Append('@');
s.Append(Time);
return s.ToString();
}
Expand Down
2 changes: 1 addition & 1 deletion pkgs/sdk/server/src/Interfaces/DataStoreStatus.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@ public struct DataStoreStatus

/// <inheritdoc/>
public override string ToString() =>
string.Format("DataStoreStatus({0},{1})", Available, RefreshNeeded);
string.Format("DataStoreStatus(Available={0},RefreshNeeded={1})", Available, RefreshNeeded);
}
}
Loading