fix: IfMatchContext/AndMatchContext utilize context kind.#225
Open
kinyoklion wants to merge 3 commits intomainfrom
Open
fix: IfMatchContext/AndMatchContext utilize context kind.#225kinyoklion wants to merge 3 commits intomainfrom
kinyoklion wants to merge 3 commits intomainfrom
Conversation
kinyoklion
commented
Feb 13, 2026
| } | ||
|
|
||
| [Fact] | ||
| public void AndMatchContext_TwoCustomContextKindsOnSameAttribute_StoresCorrectContextKinds() |
Member
Author
There was a problem hiding this comment.
Replication of github issue.
kinyoklion
commented
Feb 13, 2026
| } | ||
|
|
||
| [Fact] | ||
| public void AndMatchContext_TwoCustomContextKindsOnSameAttribute_EvaluatesCorrectly() |
Member
Author
There was a problem hiding this comment.
Also customer replication.
Member
Author
|
bugbot review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
tanderson-ld
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #224
Note
Low Risk
Change is limited to
TestData’s in-memory flag construction for tests plus new test coverage; it should not affect production data sources, with low regression risk outside test helpers.Overview
Fixes
TestDatarule-building so clauses created viaIfMatchContext/AndMatchContext(and the negated variants) actually store and emit the specifiedContextKindinto the SDK data model (Internal.Model.Clause), while treatingContextKind.Defaultasnullfor consistency.Adds comprehensive unit and integration tests verifying correct clause serialization and end-to-end evaluation for single- and multi-context scenarios, mixed default/user vs custom kinds, and negated clauses.
Written by Cursor Bugbot for commit 39692cf. This will update automatically on new commits. Configure here.