feat(drive): add secure label shortcuts#985
Open
caojie0621 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
domain/ccm
📝 WalkthroughWalkthroughThis PR adds two Drive secure-label CLI shortcuts: ChangesDrive Secure-Label Commands
Possibly related PRs
Suggested labels
Suggested reviewers
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@7125f6b3146629b3c7841f42d640425857a6ed37🧩 Skill updatenpx skills add larksuite/cli#feat/srcret -y -g |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #985 +/- ##
==========================================
+ Coverage 67.58% 67.61% +0.02%
==========================================
Files 575 576 +1
Lines 54269 54329 +60
==========================================
+ Hits 36679 36733 +54
- Misses 14548 14551 +3
- Partials 3042 3045 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
skills/lark-drive/references/lark-drive-secure-label.md (1)
44-50: 💤 Low valueConsider clarifying "重试" to avoid ambiguity.
Line 48 使用 "重试" (retry) which could be misinterpreted as automatic API retry, though line 50 clarifies that automatic retry should not happen. To eliminate ambiguity, consider rephrasing line 48 guidance to "提示用户打开目标文档，在文档界面完成密级降级审批后再次执行命令" to make it explicit that the user should manually re-run the command rather than relying on automatic retry logic.
📝 Suggested clarification
-| `1063013` | 密级降级需要审批 | 提示用户打开目标文档，在文档界面完成密级降级审批后重试；如果用户传入的是文档 URL，必须把该 URL 一并给用户作为操作入口 | +| `1063013` | 密级降级需要审批 | 提示用户打开目标文档，在文档界面完成密级降级审批后再次执行命令；如果用户传入的是文档 URL，必须把该 URL 一并给用户作为操作入口 |🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/lark-drive/references/lark-drive-secure-label.md` around lines 44 - 50, Update the guidance text for error code `1063013` to avoid ambiguity about "重试": replace the phrase "提示用户打开目标文档，在文档界面完成密级降级审批后重试" with an explicit instruction such as "提示用户打开目标文档，在文档界面完成密级降级审批后再次执行命令（请用户手动重新运行，而非依赖自动重试）" so it clearly differentiates manual user re-run from any automatic API retry logic in the `1063013` table entry.shortcuts/drive/drive_secure_label_test.go (1)
146-147: ⚡ Quick winTighten the downgrade test to assert inferred
type=docxon execute path.This stub currently allows a pass without verifying the inferred type query in this specific error-path test. Use the typed URL (or an equivalent captured-query assertion) to lock this contract.
Proposed fix
- URL: "/open-apis/drive/v2/files/doxTok123/secure_label", + URL: "/open-apis/drive/v2/files/doxTok123/secure_label?type=docx",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shortcuts/drive/drive_secure_label_test.go` around lines 146 - 147, The test's error-path stub currently checks only the path "/open-apis/drive/v2/files/doxTok123/secure_label" and Status 403 but doesn't assert that the client inferred type=docx on the execute path; update the test in drive_secure_label_test.go to expect the typed URL (e.g. include the query "type=docx") or add an assertion on the mock server's captured query params so the outgoing request contains type=docx, ensuring the mocked handler for the secure_label endpoint verifies the inferred type before returning 403.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shortcuts/drive/drive_secure_label.go`:
- Around line 135-137: The code appends rawTarget directly to hint which may
leak sensitive query or fragment data; update the logic in the function that
sets hint (the block using rawTarget and hint) to parse rawTarget with net/url
(e.g., url.Parse), zero out or omit the RawQuery and Fragment components, then
append the sanitized URL form (scheme://host/path or url.String() after clearing
query/fragment) instead of rawTarget so only a safe URL is logged.
---
Nitpick comments:
In `@shortcuts/drive/drive_secure_label_test.go`:
- Around line 146-147: The test's error-path stub currently checks only the path
"/open-apis/drive/v2/files/doxTok123/secure_label" and Status 403 but doesn't
assert that the client inferred type=docx on the execute path; update the test
in drive_secure_label_test.go to expect the typed URL (e.g. include the query
"type=docx") or add an assertion on the mock server's captured query params so
the outgoing request contains type=docx, ensuring the mocked handler for the
secure_label endpoint verifies the inferred type before returning 403.
In `@skills/lark-drive/references/lark-drive-secure-label.md`:
- Around line 44-50: Update the guidance text for error code `1063013` to avoid
ambiguity about "重试": replace the phrase "提示用户打开目标文档，在文档界面完成密级降级审批后重试" with an
explicit instruction such as
"提示用户打开目标文档，在文档界面完成密级降级审批后再次执行命令（请用户手动重新运行，而非依赖自动重试）" so it clearly
differentiates manual user re-run from any automatic API retry logic in the
`1063013` table entry.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e0941114-fc6e-4da7-ac41-8afffdfed33d
📒 Files selected for processing (8)
shortcuts/drive/drive_secure_label.goshortcuts/drive/drive_secure_label_test.goshortcuts/drive/shortcuts.goshortcuts/drive/shortcuts_test.goskills/lark-drive/SKILL.mdskills/lark-drive/references/lark-drive-secure-label.mdtests/cli_e2e/drive/coverage.mdtests/cli_e2e/drive/drive_secure_label_dryrun_test.go
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
shortcuts/drive/drive_secure_label_test.go (1)
161-163: ⚡ Quick winAssert the
1063013actionable hint in the downgrade-error test.This test currently verifies only the raw API message. Please also assert the user-facing downgrade-approval hint text so the intended behavior is regression-safe.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@shortcuts/drive/drive_secure_label_test.go` around lines 161 - 163, The test currently only checks the raw API error string (err.Error()); update the test in drive_secure_label_test.go (the downgrade-error assertion block where err is checked) to also assert that the user-facing actionable hint is present by verifying either the hint ID "1063013" or the corresponding user-facing downgrade-approval message appears in the error output; add a second assertion after the existing strings.Contains check that fails the test if the actionable hint text (or "1063013") is missing so the downgrade-approval hint is covered by the test.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shortcuts/drive/drive_secure_label.go`:
- Around line 103-105: The error return path in drive_secure_label.go (the block
that currently does "if err != nil { return err }") must detect when the API
error contains code 1063013 and, in that case, write a clear downgrade-approval
hint to stderr (use fmt.Fprintln(os.Stderr, "...") or log.New(os.Stderr, ...))
while still returning the original API error (or wrapping it without losing the
original error value, e.g., fmt.Errorf("%w", err)). Modify the error branch in
the function handling "+secure-label-update" to inspect the API error type or
message for code 1063013, emit the guidance to stderr, and then return the
original error so the API context is preserved and stdout remains untouched.
---
Nitpick comments:
In `@shortcuts/drive/drive_secure_label_test.go`:
- Around line 161-163: The test currently only checks the raw API error string
(err.Error()); update the test in drive_secure_label_test.go (the
downgrade-error assertion block where err is checked) to also assert that the
user-facing actionable hint is present by verifying either the hint ID "1063013"
or the corresponding user-facing downgrade-approval message appears in the error
output; add a second assertion after the existing strings.Contains check that
fails the test if the actionable hint text (or "1063013") is missing so the
downgrade-approval hint is covered by the test.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7f9edd9e-ae6b-488e-afb2-eb12626fefbc
📒 Files selected for processing (8)
shortcuts/drive/drive_secure_label.goshortcuts/drive/drive_secure_label_test.goshortcuts/drive/shortcuts.goshortcuts/drive/shortcuts_test.goskills/lark-drive/SKILL.mdskills/lark-drive/references/lark-drive-secure-label.mdtests/cli_e2e/drive/coverage.mdtests/cli_e2e/drive/drive_secure_label_dryrun_test.go
✅ Files skipped from review due to trivial changes (3)
- skills/lark-drive/SKILL.md
- skills/lark-drive/references/lark-drive-secure-label.md
- tests/cli_e2e/drive/coverage.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drive +secure-label-listto list secure labels available to the current user.drive +secure-label-updateto update a Drive file/document secure label.1063013handling with an actionable hint directing users to complete downgrade approval in the document UI.Test Plan
go test ./shortcuts/drivego test ./tests/cli_e2e/drive -run TestDrive_SecureLabelDryRunSummary by CodeRabbit
New Features
+secure-label-listto list available secure labels and+secure-label-updateto set a secure label on files/documents (supports dry-run).Documentation
Tests