docs: clarify contributor guidance#983
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (3)
📝 WalkthroughWalkthroughThree documentation files updated: the PR template's manual verification checklist now references ChangesContributor Documentation and Workflow Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I'm Junyang. I have already received your letter.
|
6a4587e to
406e0de
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #983 +/- ##
==========================================
+ Coverage 67.58% 67.59% +0.01%
==========================================
Files 575 575
Lines 54269 54269
==========================================
+ Hits 36679 36685 +6
+ Misses 14548 14543 -5
+ Partials 3042 3041 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@406e0dee6a8e714acd43f333045456f41925bf3e🧩 Skill updatenpx skills add JulyanXu/cli#codex/contributor-guidance -y -g |
|
Hi @JulyanXu — the lint failure isn't from your changes. It's pointing at shortcuts/sheets/lark_sheets_cell_images.go:14 (depguard shortcuts-no-vfs), which this PR doesn't touch. Root cause: your branch is 13 commits behind main. The vfs import on that line was already removed on main by #996 (fix(sheets): use FileIO for write-image input), but it still Quick fix — no PR content change needed, just sync the branch: gh pr checkout 983 Once the merge lands, lark_sheets_cell_images.go picks up the main-side fix and lint will pass. The PR itself looks good to me — happy to approve after CI is green. |
Summary
Clarify contributor-facing guidance by linking the README contribution sections to
AGENTS.md, where the repository already keeps the local build, test, and PR checklist. Also update the PR template example command from the oldlark xxxplaceholder to the actuallark-cli <domain> <command>form.Changes
AGENTS.mdlark-cli <domain> <command>Test Plan
git diff --checkmake fmt-checknode scripts/skill-format-check/index.jslark-cli <domain> <command>flow works as expected — not applicable; no CLI behavior changeRelated Issues
Summary by CodeRabbit