Skip to content

fix: remove DNS lookup from ValidateDownloadSourceURL to eliminate network-dependent test failures #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CharliePuth0 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −13
Open

fix: remove DNS lookup from ValidateDownloadSourceURL to eliminate network-dependent test failures #1003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions internal/validate/url.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ func isRestrictedDownloadIP(ip net.IP) bool {
}

// ValidateDownloadSourceURL validates a download URL and blocks local/internal targets.
// IP-based restriction is enforced at the transport layer (see validateConnRemoteIP),
// which provides defense-in-depth against DNS rebinding that a pre-connect DNS lookup
// cannot catch.
func ValidateDownloadSourceURL(ctx context.Context, rawURL string) error {
_ = ctx
u, err := url.Parse(rawURL)
if err != nil || u == nil {
return fmt.Errorf("invalid URL")
Expand All @@ -87,19 +91,6 @@ func ValidateDownloadSourceURL(ctx context.Context, rawURL string) error {
if isRestrictedDownloadIP(ip) {
return fmt.Errorf("local/internal host is not allowed")
}
return nil
}
ips, err := net.DefaultResolver.LookupIP(ctx, "ip", host)
if err != nil {
return fmt.Errorf("failed to resolve host")
}
if len(ips) == 0 {
return fmt.Errorf("failed to resolve host")
}
for _, ip := range ips {
if isRestrictedDownloadIP(ip) {
return fmt.Errorf("local/internal host is not allowed")
}
}
return nil
}
Expand Down
Loading