-
Notifications
You must be signed in to change notification settings - Fork 19
InternalEnergyFromDensityPressure #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note a few things:
|
Yurlungur
commented
Nov 26, 2025
Yurlungur
commented
Nov 26, 2025
rbberger
reviewed
Dec 1, 2025
rbberger
reviewed
Dec 4, 2025
rbberger
reviewed
Dec 4, 2025
Collaborator
Author
|
I believe this is ready for review no. Thanks @rbberger ! @adamdempsey90 can you take a look? |
adamdempsey90
approved these changes
Dec 4, 2025
Collaborator
Author
|
@rbberger do you want to merge this? Or should we hold off still? |
rbberger
approved these changes
Dec 19, 2025
Collaborator
|
@Yurlungur I would say go for it. If we need more I'll reach out next year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
As requested by @rbberger for Ristra, I add here a method for
InternalEnergyFromDensityPressure. This method ports into singularity-eos the same machinery used by Phoebus and riot (hence why I ping @AstroBarker, @pdmullen , and @jdolence ). Going forward, this will reduce code duplication as those downstream codes will no longer need to implement the method themselves.PR Checklist
make formatcommand after configuring withcmake.If preparing for a new release, in addition please check the following:
when='@main'dependencies are updated to the release version in the package.py