Skip to content

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Jan 12, 2026

Description

fix #383

Example Metrics

Visit http://localhost:5002/metrics to see:

Plugin invocation count

plugin_invocations_total{plugin_id="openai",plugin_type="model",runtime_type="local",operation="invoke_llm",status="success"} 1234

Plugin invocation latency (histogram)

plugin_invocation_duration_seconds{plugin_id="openai",plugin_type="model",runtime_type="local",operation="invoke_llm"}

Current active invocations

plugin_invocations_active{plugin_id="openai",plugin_type="model",runtime_type="local"} 2

Plugin runtime status

plugin_runtime_status{plugin_id="openai",runtime_type="local"} 1

Active plugins

active_plugins_total{runtime_type="local"} 15

Plugin installation count

plugin_installations_total{plugin_id="openai",status="success"} 5

Plugin restart count

plugin_restarts_total{plugin_id="openai",runtime_type="local"} 1

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 12, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the application's observability by integrating Prometheus metrics. It provides a detailed view into the system's performance and behavior, covering HTTP request handling, the lifecycle of plugins from installation to runtime, and their invocation patterns. This will allow for better monitoring and debugging of the application's operations.

Highlights

  • Prometheus Metrics Integration: Introduced comprehensive Prometheus metrics to monitor various aspects of the application, including HTTP requests, plugin invocations, and plugin lifecycle events.
  • New Metrics Endpoint: A new /metrics HTTP endpoint has been added to expose the collected Prometheus metrics, making them accessible for monitoring systems.
  • Plugin Observability: Detailed metrics are now collected for plugin activities such as invocation counts, invocation latency, active invocations, installation status, installation duration, runtime status, and active plugin counts.
  • HTTP Request Monitoring: Implemented middleware to track total HTTP requests and their durations, categorized by method, endpoint, and status.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added enhancement New feature or request go Pull requests that update go code plugin-daemon labels Jan 12, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Prometheus metrics for monitoring various aspects of the application, including HTTP requests, plugin invocations, installations, and runtime status. This is a valuable addition for observability. The implementation is solid, but I've identified a critical issue with metric cardinality in the HTTP middleware that could negatively affect your Prometheus instance. Additionally, I've suggested several refactorings to address code duplication and improve maintainability. Overall, great work on enhancing the application's monitoring capabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request go Pull requests that update go code plugin-daemon size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support OpenTelemetry OTLP Exporter in plugin_daemon

3 participants