-
Notifications
You must be signed in to change notification settings - Fork 272
feat: add prometheus metric #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the application's observability by integrating Prometheus metrics. It provides a detailed view into the system's performance and behavior, covering HTTP request handling, the lifecycle of plugins from installation to runtime, and their invocation patterns. This will allow for better monitoring and debugging of the application's operations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Prometheus metrics for monitoring various aspects of the application, including HTTP requests, plugin invocations, installations, and runtime status. This is a valuable addition for observability. The implementation is solid, but I've identified a critical issue with metric cardinality in the HTTP middleware that could negatively affect your Prometheus instance. Additionally, I've suggested several refactorings to address code duplication and improve maintainability. Overall, great work on enhancing the application's monitoring capabilities.
Description
fix #383
Example Metrics
Visit http://localhost:5002/metrics to see:
Plugin invocation count
plugin_invocations_total{plugin_id="openai",plugin_type="model",runtime_type="local",operation="invoke_llm",status="success"} 1234
Plugin invocation latency (histogram)
plugin_invocation_duration_seconds{plugin_id="openai",plugin_type="model",runtime_type="local",operation="invoke_llm"}
Current active invocations
plugin_invocations_active{plugin_id="openai",plugin_type="model",runtime_type="local"} 2
Plugin runtime status
plugin_runtime_status{plugin_id="openai",runtime_type="local"} 1
Active plugins
active_plugins_total{runtime_type="local"} 15
Plugin installation count
plugin_installations_total{plugin_id="openai",status="success"} 5
Plugin restart count
plugin_restarts_total{plugin_id="openai",runtime_type="local"} 1
Type of Change
Essential Checklist
Testing
Bug Fix (if applicable)
Fixes #123orCloses #123)Additional Information
Please provide any additional context that would help reviewers understand the changes.