-
Notifications
You must be signed in to change notification settings - Fork 683
[Feat] Add timeout and strip image html tags for PaddleOCR plugin #2373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Add timeout and strip image html tags for PaddleOCR plugin #2373
Conversation
Summary of ChangesHello @Bobholamovic, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the PaddleOCR plugin by improving its reliability and the quality of its output. It introduces request timeouts for all external API calls, coupled with robust error handling, to prevent the plugin from hanging and to provide more informative feedback on failures. Furthermore, it refines the markdown output from document parsing by stripping out extraneous HTML image tags, resulting in a cleaner and more focused textual representation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several valuable improvements to the PaddleOCR plugin. It enhances robustness by adding a request timeout to API calls and properly handling timeout exceptions. It also cleans up the output of document parsing tools by stripping HTML image tags. The version bump and the fix for the authorization header are also correctly implemented. My main feedback is about a minor code duplication issue with the REQUEST_TIMEOUT constant, which is defined in three different files. I've suggested centralizing it in the new tools/utils.py module to improve maintainability. Overall, this is a good set of changes.
This PR contains Changes to Non-LLM Models Plugin
Version Control (Any Changes to the Plugin Will Require Bumping the Version)
VersionField, Not in Meta Section)Dify Plugin SDK Version
dify_plugin>=0.3.0,<0.6.0is in requirements.txt (SDK docs)