-
Notifications
You must be signed in to change notification settings - Fork 683
ff #2239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ff #2239
Conversation
Summary of ChangesHello @QIN2DIM, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the configuration and capabilities of the DeepSeek-V3.2 large language model. It introduces support for advanced features like multi-tool calls and structured output, while also refining its parameter definitions for better clarity and control. A new dynamic schema patching mechanism is implemented to ensure consistent and correct model setup. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the configuration for the DeepSeek V3.2 model and refactors how customizable model schemas are handled. The changes in the YAML file add new features and redefine the temperature parameter. The Python code introduces a helper class to apply model-specific patches and modifies the logic for generating customizable model schemas.
My review has identified a few issues that should be addressed:
- A copy-paste error in a user-facing help text.
- Leftover debug code that should be removed.
- Opportunities to improve maintainability by using constants for static data.
Please see the detailed comments below.
| ) | ||
| entity = super().get_customizable_model_schema(model, credentials) | ||
|
|
||
| print(entity) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| en_US: For Gemini 3, best results at default 1.0. Lower values may impact reasoning. | ||
| zh_Hans: 对于 Gemini 3,使用默认值 1.0 可获得最佳效果。数值过低可能会影响推理能力。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The help text for temperature appears to be incorrect. It mentions "Gemini 3", but this configuration is for a DeepSeek model. This was likely a copy-paste error and should be corrected to refer to the correct model to avoid confusing users.
en_US: For DeepSeek V3.2, best results at default 1.0. Lower values may impact reasoning.
zh_Hans: 对于 DeepSeek V3.2,使用默认值 1.0 可获得最佳效果。数值过低可能会影响推理能力.| pending_features = [ | ||
| ModelFeature.TOOL_CALL, | ||
| ModelFeature.MULTI_TOOL_CALL, | ||
| ModelFeature.STREAM_TOOL_CALL, | ||
| ModelFeature.AGENT_THOUGHT, | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| entity = super().get_customizable_model_schema(model, credentials) | ||
|
|
||
| print(entity) | ||
| if model in ["deepseek-ai/DeepSeek-V3.2", "Pro/deepseek-ai/DeepSeek-V3.2"]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better maintainability and performance, consider defining these model names as a module-level set constant. Using a set is more efficient for membership testing than a list.
| if model in ["deepseek-ai/DeepSeek-V3.2", "Pro/deepseek-ai/DeepSeek-V3.2"]: | |
| if model in {"deepseek-ai/DeepSeek-V3.2", "Pro/deepseek-ai/DeepSeek-V3.2"}: |
Related Issues or Context
This PR contains Changes to Non-Plugin
This PR contains Changes to Non-LLM Models Plugin
This PR contains Changes to LLM Models Plugin
Version Control (Any Changes to the Plugin Will Require Bumping the Version)
VersionField, Not in Meta Section)Dify Plugin SDK Version
dify_plugin>=0.3.0,<0.6.0is in requirements.txt (SDK docs)Environment Verification (If Any Code Changes)
Local Deployment Environment
SaaS Environment