Skip to content

fix: add CONTROL_FLOW_EXCEPTION_TYPES check to on_tool_error, on_retriever_error, and on_llm_error #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vishnumishra wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: add CONTROL_FLOW_EXCEPTION_TYPES check to on_tool_error, on_retriever_error, and on_llm_error #1514

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c445a75
fix: add CONTROL_FLOW_EXCEPTION_TYPES check to on_tool_error, on_retr…
vishnumishra Feb 9, 2026
8a9016d
Merge branch 'main' into fix/control-flow-exception-check-in-error-ha…
vishnumishra Feb 9, 2026
f40fda7
fix: use DEFAULT level and preserve status_message for control-flow e…
vishnumishra Feb 9, 2026
c49a31f
Merge branch 'main' into fix/control-flow-exception-check-in-error-ha…
vishnumishra Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 28 additions & 5 deletions langfuse/langchain/CallbackHandler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,11 +255,19 @@ def on_retriever_error(
self._log_debug_event(
"on_retriever_error", run_id, parent_run_id, error=error
)
if any(isinstance(error, t) for t in CONTROL_FLOW_EXCEPTION_TYPES):
level = "DEFAULT"
else:
level = "ERROR"

observation = self._detach_observation(run_id)

if observation is not None:
observation.update(
level="ERROR",
level=cast(
Optional[Literal["DEBUG", "DEFAULT", "WARNING", "ERROR"]],
level,
),
status_message=str(error),
input=kwargs.get("inputs"),
cost_details={"total": 0},
Expand Down Expand Up @@ -581,7 +589,7 @@ def on_chain_error(
try:
self._log_debug_event("on_chain_error", run_id, parent_run_id, error=error)
if any(isinstance(error, t) for t in CONTROL_FLOW_EXCEPTION_TYPES):
level = None
level = "DEFAULT"
else:
level = "ERROR"

Expand All @@ -593,7 +601,7 @@ def on_chain_error(
Optional[Literal["DEBUG", "DEFAULT", "WARNING", "ERROR"]],
level,
),
status_message=str(error) if level else None,
status_message=str(error),
input=kwargs.get("inputs"),
cost_details={"total": 0},
).end()
Expand Down Expand Up @@ -803,12 +811,20 @@ def on_tool_error(
) -> Any:
try:
self._log_debug_event("on_tool_error", run_id, parent_run_id, error=error)
if any(isinstance(error, t) for t in CONTROL_FLOW_EXCEPTION_TYPES):
level = "DEFAULT"
else:
level = "ERROR"

observation = self._detach_observation(run_id)

if observation is not None:
observation.update(
level=cast(
Optional[Literal["DEBUG", "DEFAULT", "WARNING", "ERROR"]],
level,
),
status_message=str(error),
level="ERROR",
input=kwargs.get("inputs"),
cost_details={"total": 0},
).end()
Expand Down Expand Up @@ -997,13 +1013,20 @@ def on_llm_error(
) -> Any:
try:
self._log_debug_event("on_llm_error", run_id, parent_run_id, error=error)
if any(isinstance(error, t) for t in CONTROL_FLOW_EXCEPTION_TYPES):
level = "DEFAULT"
else:
level = "ERROR"

generation = self._detach_observation(run_id)

if generation is not None:
generation.update(
level=cast(
Optional[Literal["DEBUG", "DEFAULT", "WARNING", "ERROR"]],
level,
),
status_message=str(error),
level="ERROR",
input=kwargs.get("inputs"),
cost_details={"total": 0},
).end()
Expand Down