Fix: Break Manager #138
Merged
Fix: Break Manager #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new serverSwap setting. this seems to be on par with 1.20.4 consistency but there are improvements to be made regarding speed
…rimary breaks as to not drag them down
… can take for optimal efficiency and leave stack selection check to the break manager too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a more immutable style system for item swapping logic. Each tick a new SwapInfo is created for all active break infos.
This also fixes an issue with redundancy spam due to the build tasks request logic.
Along with the fixes, ive added a new "Server Swap" setting for the user to edit how many ticks the server should be given to recognise the selected tool. This is hard limited to a minimum of 2 ticks for secondary breaks to allow the user to select 0 for servers < 1.21.5 that dont apply certain enchantments, like efficiency, as player attributes