[1.20.4] Ref: Http library #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 9 out of 13 changed files in this pull request and generated 2 comments.
Files not reviewed (4)
- common/build.gradle.kts: Language not supported
- fabric/build.gradle.kts: Language not supported
- forge/build.gradle.kts: Language not supported
- gradle.properties: Language not supported
| contentType(ContentType.Application.Json) | ||
| } | ||
|
|
||
| check(resp.status == HttpStatusCode.OK) |
There was a problem hiding this comment.
Using 'check' to validate the response status may obscure error details if the request fails. Consider returning a Result with a descriptive error or throwing a custom exception that provides more context.
Comment on lines
+77
to
+85
| val output = ByteArrayOutputStream() | ||
|
|
||
| LambdaHttp.download(cape.url, output) | ||
|
|
||
| val bytes = output.toByteArray() | ||
| destination.writeBytes(bytes) | ||
|
|
||
| val image = TextureUtils.readImage(bytes) | ||
| val native = NativeImageBackedTexture(image) |
There was a problem hiding this comment.
[nitpick] Since LambdaHttp provides an overload to write directly to a file, consider using that version instead of writing to a ByteArrayOutputStream and then saving the bytes manually.
emyfops
added
ignore-for-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces Fuel by Ktor
In order to include ktor correctly, some changes were required in the build files