Open
Conversation
Barecheck - Code coverage reportTotal: 96.34%Your code coverage diff: 0.00% ▴ Uncovered files and lines
|
Uvicorn uses the now deprecated `websockets.legacy` back end by default. It also supports the newer `sansio` interface. As far as I can tell, either works, so I'm not sure why legacy is the default: backwards compatibility I guess. I'd like to switch to the newer implementation now, before we are using websockets in anger, as it feels wrong to start out with deprecation warnings in the test suite!
rwb27
force-pushed
the
websockets-sansio
branch
from
a1db57e to
f1dc80d
Compare
julianstirling
requested changes
Mar 25, 2026
Contributor
julianstirling
left a comment
julianstirling
left a comment
There was a problem hiding this comment.
This generally make sense. I think the worry is there will be inconsistent behaviour if people follow the example in tutorial/writing_a_thing.rst. Even though websockets are not in use it is probably worth updating that example.
This also relates to #263 as the OFM has its own uvicorn.run lines. I am not sure how best to wrap this so it can be enabled. But at the minimum I'd update the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uvicorn uses the now deprecated
websockets.legacyback end by default. It also supports the newersansiointerface. As far as I can tell, either works, so I'm not sure why legacy is the default: backwards compatibility I guess.I'd like to switch to the newer implementation now, before we are using websockets in anger, as it feels wrong to start out with deprecation warnings in the test suite! I don't believe we will notice the difference, but hopefully the test suite will tell. Websockets aren't used yet by the OFM.