Open
Conversation
rwb27
force-pushed
the
validate-properties-on-assignment
branch
from
5a37ae6 to
9f819fd
Compare
This uses the existing validation logic in `PropertyInfo` to check assignments made in Python as well as set operations over HTTP.
I've added a module-level `FEATURE_FLAGS` object. This means validation of properties on set is disabled by default, but may be enabled if it's wanted. The test suite checks both cases, and I've added a context manager to avoid accidental state leakage between tests.
rwb27
force-pushed
the
validate-properties-on-assignment
branch
from
9f819fd to
5fca4f1
Compare
This makes sure we can't accidentally set flags that don't exist, which ought to help downstream code.
rwb27
force-pushed
the
validate-properties-on-assignment
branch
from
e2d191f to
75b7388
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes use of the validation logic now added to
PropertyInfoto validate properties when they are set from Python. Properties are already validated when set over HTTP.I've added to existing tests to ensure that we test this in various ways, both by calling
__set__on a mockedThingand in more realistic contexts.I have added
lt.FEATURE_FLAGSwhich makes this an opt-in feature. That should mean that we can test against the OFM codebase as-is, and that it should pass when we use a feature branch that enables validation.It's slightly unfortunate that this PR now contains two new things (feature flags and validation) but it didn't make sense to merge one without the other.
OFM Feature Branch: v3-labthings-validate-properties-on-set