Loosen timing tolerances #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows timing jitter is not infrequently bad enough that it takes longer than 0.04s for some of the cancellation-related tests to run. I've increased the timings to stop them failing because of jitter.
Barecheck - Code coverage reportTotal: 96.33%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
julianstirling
approved these changes
Jan 12, 2026
Contributor
julianstirling
left a comment
julianstirling
left a comment
There was a problem hiding this comment.
I have occasionally seen one of these fail in Linux. Nothing is immune from timing jitter, these tolerances are still tight enough to be a test of functionality.
Collaborator
Author
|
I've definitely seen them fail more often under 'doze, but I agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows timing jitter is not infrequently bad enough that it takes longer than 0.04s for some of the cancellation-related tests to run. I've increased the timings to stop them failing because of jitter.