fix(devbox): support v1.7 metadata layout#31
Open
lingdie wants to merge 1 commit into
Open
Conversation
lingdie
force-pushed
the
codex/devbox-v17-metadata-compat
branch
2 times, most recently
from
3d30031 to
3058817
Compare
lingdie
changed the title
Restore devbox snapshot metadata reads and writes to the v1.7 varint and single-byte encodings instead of the fixed 8-byte encoding used in the v2.2 backport. Store and read devbox content records from the v1 root devbox_storage_path bucket so upgraded nodes can keep using v1.7 metadata.db. Add storage coverage for v1.7 metadata reads, legacy-format writes, and the legacy devbox content root bucket.
lingdie
force-pushed
the
codex/devbox-v17-metadata-compat
branch
from
3058817 to
2f2fa96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devbox_storage_pathbucketmetadata.dbcompatibility; no 8-byte metadata compatibility or alternate bucket fallback is includedTests
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go test -c ./plugins/snapshots/devbox/storage -o /tmp/devbox-storage.test/tmp/devbox-storage-v17-only.test -test.vonroot@192.168.10.230CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -o /tmp/containerd-devbox-v17-only ./cmd/containerdNote
This intentionally supports only the v1.7
metadata.dblayout. It does not add compatibility for any temporary 8-byte big-endian metadata written by the earlier v2.2 backport.