Skip to content

Conversation

@seedspirit
Copy link
Contributor

resolves #7555 (BA-3532)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@seedspirit seedspirit self-assigned this Dec 21, 2025
@github-actions github-actions bot added size:L 100~500 LoC comp:manager Related to Manager component labels Dec 21, 2025
@seedspirit seedspirit changed the title refactor(BA-3532): Apply action-processor pattern in registry deletion API refactor(BA-3532): Apply action-processor pattern in container registry deletion API Dec 21, 2025
@seedspirit seedspirit marked this pull request as ready for review December 21, 2025 09:32
Copilot AI review requested due to automatic review settings December 21, 2025 09:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the container registry deletion API to follow the action-processor pattern, replacing direct database operations in GraphQL mutations with a structured service layer approach. This improves code organization, maintainability, and consistency with other container registry operations.

Key changes:

  • Introduced DeleteContainerRegistryAction and associated components following the action-processor pattern
  • Migrated GraphQL mutations (both v1 and v2) from direct database operations to use the new action processor
  • Added comprehensive test coverage for the deletion functionality

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/ai/backend/manager/services/container_registry/actions/delete_container_registry.py New action definition for container registry deletion with action and result dataclasses
src/ai/backend/manager/services/container_registry/service.py Added delete_container_registry service method that delegates to repository
src/ai/backend/manager/services/container_registry/processors.py Registered delete action processor and added to supported actions list
src/ai/backend/manager/repositories/container_registry/repository.py Implemented delete_registry repository method with proper error handling
src/ai/backend/manager/models/gql_models/container_registry.py Refactored DeleteContainerRegistryNode mutation to use action-processor pattern
src/ai/backend/manager/models/gql_models/container_registry_v2.py Refactored DeleteContainerRegistryNodeV2 mutation to use action-processor pattern
tests/manager/repositories/container_registry/test_container_registry_repository.py Added test fixtures and three test cases for delete functionality
changes/7559.enhance.md Changelog entry documenting the enhancement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@seedspirit seedspirit requested review from HyeockJinKim, fregataa and jopemachine and removed request for jopemachine December 22, 2025 01:41
@HyeockJinKim HyeockJinKim added this pull request to the merge queue Dec 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 27, 2025
@HyeockJinKim HyeockJinKim added this pull request to the merge queue Dec 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 27, 2025
@HyeockJinKim HyeockJinKim added this pull request to the merge queue Dec 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 27, 2025
@HyeockJinKim
Copy link
Collaborator

Please check test failure (In merge queue) @seedspirit

@HyeockJinKim HyeockJinKim added this pull request to the merge queue Dec 30, 2025
Merged via the queue into main with commit 6507937 Dec 30, 2025
29 of 30 checks passed
@HyeockJinKim HyeockJinKim deleted the refactor/BA-3532 branch December 30, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:manager Related to Manager component size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce action-processor pattern in Container Registry deletion

3 participants