feat(BA-3399): Implement AutoScalingRule strawberry GraphQL DataLoaders
#7428
+237
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jopemachine
changed the title
AutoScalingRule strawberry GraphQL DataLoadersAutoScalingRule strawberry GraphQL DataLoaders
Comment on lines
14
to
15
| async def load_auto_scaling_rules_by_ids( | ||
| processor: Optional[DeploymentProcessors], |
Collaborator
There was a problem hiding this comment.
There seems to be no reason to make the processor optional.
Member
Author
There was a problem hiding this comment.
deployment: Optional[DeploymentProcessors]
deployment under Processors is Optional.
I don't know why..
Member
Author
There was a problem hiding this comment.
Comment on lines
43
to
49
| @cached_property | ||
| def auto_scaling_rule_loader( | ||
| self, | ||
| ) -> DataLoader[uuid.UUID, Optional[ModelDeploymentAutoScalingRuleData]]: | ||
| return DataLoader( | ||
| load_fn=partial(load_auto_scaling_rules_by_ids, self._processors.deployment) | ||
| ) |
Collaborator
There was a problem hiding this comment.
The original intention was to place the closure in the same place, but this is not bad either.
src/ai/backend/manager/api/gql/data_loader/auto_scaling_rule/loader.py
Outdated
Show resolved
Hide resolved
HyeockJinKim
force-pushed
the
main
branch
2 times, most recently
from
9552aac to
4af738e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7340 (BA-3399)
Checklist: (if applicable)
ai.backend.testdocsdirectory