Simplify Julian Date Computations #115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an expansion on #79 - the Julian start time is constant, since everything is in UTC.
Additionally, as far as I can tell, there is no need to do any fancy time conversions in
predict_from_julian(). We can effectively do the reverse ofpredict_to_julian(): multiply the Julian date by the seconds per day, then add JULIAN_START_DAY.We are able to remove the
mktime_utc()function after these changes, which I have found returns incorrect values in some edge cases. This works since since everything is in UTC, and removes the dependency on time functions or timezone handling.Thanks for the consideration, and your work on this great library!