Skip to content

Fix to: Breaking change in 0.42.0 - multiple database sessions #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lovelace9981 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix to: Breaking change in 0.42.0 - multiple database sessions #796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions sqlalchemy_utils/functions/database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,26 @@ def drop_database(url):
if dialect_name == 'sqlite' and database != ':memory:':
if database:
os.remove(database)
elif dialect_name == 'postgresql':
with engine.begin() as conn:
version = conn.dialect.server_version_info
if version < (13, 0):
pid_column = 'pid' if (version >= (9, 2)) else 'procpid'

text = """
SELECT pg_terminate_backend(pg_stat_activity.{pid_column})
FROM pg_stat_activity
WHERE pg_stat_activity.datname = '{database}'
AND {pid_column} <> pg_backend_pid();
""".format(pid_column=pid_column, database=database)
conn.execute(sa.text(text))

text = (
f'DROP DATABASE {quote(conn, database)}'
if version < (13, 0)
else f'DROP DATABASE {quote(conn, database)} WITH (FORCE)'
)
conn.execute(sa.text(text))
else:
with engine.begin() as conn:
text = f'DROP DATABASE {quote(conn, database)}'
Expand Down