Skip to content

Conversation

@rolljee
Copy link
Member

@rolljee rolljee commented Dec 5, 2025

Overview

  • Compatibility with nodejs 24
  • Update cucumber-js to work with typescript
  • Modify files that were left in js to typescript
  • Replacement of webpack by vite
  • Modify tsconfig.json to output javascript in out folder

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

"files": [
"dist/**/*",
"index.js",
"index.d.ts",
"src/**/*.js",

P1 Badge Ship compiled out/ artifacts in npm package

package.json now sets main to out/index.js, but the files whitelist still only exports dist/**/*, index.js, and src/**/*.js (lines 61‑65), so npm pack/npm publish will drop the newly built out directory. Any install from the registry will lack out/index.js, and require('kuzzle-sdk') will fail with “Cannot find module '…/out/index.js'”. Add the out/** output (and declarations) to the files list to keep the published package loadable.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants