Skip to content

Conversation

@kunitoki
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 74.91086% with 774 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.09%. Comparing base (ac21043) to head (7d5ad80).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ules/yup_gui/themes/theme_v1/yup_ThemeVersion1.cpp 49.62% 201 Missing ⚠️
modules/yup_gui/widgets/yup_ListBox.cpp 71.47% 162 Missing ⚠️
.../yup_audio_gui/displays/yup_AudioViewComponent.cpp 65.79% 105 Missing ⚠️
modules/yup_gui/widgets/yup_ListBoxItem.cpp 33.33% 62 Missing ⚠️
modules/yup_gui/widgets/yup_ScrollBar.cpp 80.42% 37 Missing ⚠️
...les/yup_audio_gui/metering/yup_KMeterComponent.cpp 45.90% 33 Missing ⚠️
...ules/yup_audio_gui/waveform/yup_AudioThumbnail.cpp 84.61% 30 Missing ⚠️
...es/yup_dsp/stretching/yup_TimeStretchProcessor.cpp 88.65% 27 Missing ⚠️
modules/yup_dsp/metering/yup_KMeterState.cpp 90.51% 26 Missing ⚠️
...p_audio_gui/waveform/yup_AudioPeakProfileCache.cpp 84.75% 25 Missing ⚠️
... and 20 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   72.22%   73.09%   +0.86%     
==========================================
  Files         519      545      +26     
  Lines       50801    53793    +2992     
==========================================
+ Hits        36691    39318    +2627     
- Misses      14110    14475     +365     
Files with missing lines Coverage Δ
.../yup_audio_formats/formats/yup_WaveAudioFormat.cpp 76.52% <100.00%> (ø)
modules/yup_dsp/frequency/yup_FFTProcessor.h 0.00% <ø> (ø)
modules/yup_dsp/metering/yup_LoudnessFilter.cpp 100.00% <100.00%> (ø)
modules/yup_events/messages/yup_MessageManager.cpp 53.07% <100.00%> (+4.61%) ⬆️
modules/yup_graphics/graphics/yup_Color.h 93.54% <ø> (ø)
modules/yup_graphics/primitives/yup_Path.cpp 86.94% <100.00%> (+0.10%) ⬆️
modules/yup_graphics/primitives/yup_Path.h 100.00% <ø> (ø)
modules/yup_graphics/primitives/yup_Rectangle.h 98.99% <100.00%> (+0.01%) ⬆️
modules/yup_gui/buttons/yup_TextButton.cpp 100.00% <100.00%> (+12.50%) ⬆️
modules/yup_gui/buttons/yup_TextButton.h 100.00% <ø> (+50.00%) ⬆️
... and 41 more

... and 39 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d8e48b...7d5ad80. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kunitoki kunitoki requested a review from Copilot January 23, 2026 17:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements comprehensive audio processing and visualization features, including metering, waveform display, and time-stretching capabilities.

Changes:

  • Added K-Meter implementation with ITU BS.1770-4 loudness filtering and real-time level processing
  • Introduced audio waveform visualization with multi-resolution peak profiling and caching
  • Implemented new GUI widgets (ScrollBar, ProgressBar, ListBox) with theme integration
  • Added time-stretching processor with Bungee backend support

Reviewed changes

Copilot reviewed 113 out of 252 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/yup_dsp/yup_LevelProcessor.cpp Comprehensive unit tests for LevelProcessor covering RMS, peak detection, and ballistics
modules/yup_dsp/metering/* New metering components: LevelProcessor, LoudnessFilter, and KMeterState for audio level measurement
modules/yup_audio_gui/waveform/* Waveform rendering infrastructure with AudioPeakProfile, caching, and AudioThumbnail
modules/yup_gui/widgets/* New widgets (ScrollBar, ProgressBar, ListBox) for UI components
modules/yup_simd/* SIMD operations module extracted from yup_audio_basics for better organization
justfile Visual Studio version updated to 2026
AGENTS.md, CLAUDE.md Copyright year updated to 2026
Comments suppressed due to low confidence (1)

AGENTS.md:1

  • The copyright year 2026 is in the future. Since it is currently January 23, 2026, this should be 2025 to reflect when the work was done.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants