Skip to content

Conversation

@stephenfin
Copy link
Member

@stephenfin stephenfin commented Jan 23, 2026

What this PR does / why we need it:

Bump gophercloud and other dependencies to their latest versions ahead of
cutting the release-1.35 branch.

Which issue this PR fixes(if applicable):

None.

Special notes for reviewers:

This should probably land before #3054.

Discussed on Slack. We can land this after.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 23, 2026
@k8s-ci-robot k8s-ci-robot requested review from dulek and kayrus January 23, 2026 14:42
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 23, 2026
@kayrus
Copy link
Contributor

kayrus commented Jan 23, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kayrus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2026
@mnaser
Copy link
Contributor

mnaser commented Jan 23, 2026

pkg/openstack/loadbalancer_sg.go:79:7: SA1019: slices.Contains is deprecated: use stdlib slices.Contains instead. (staticcheck)
			if slices.Contains(port.SecurityGroups, sg) {
			   ^
pkg/openstack/loadbalancer_sg.go:135:6: SA1019: slices.Contains is deprecated: use stdlib slices.Contains instead. (staticcheck)
		if slices.Contains(port.Tags, sg) {
		   ^

I'm confused why those are firing..

The bumped k8s.io/utils deprecates the slices lib so we switch to
the stdlib variant.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2026
@stephenfin
Copy link
Member Author

pkg/openstack/loadbalancer_sg.go:79:7: SA1019: slices.Contains is deprecated: use stdlib slices.Contains instead. (staticcheck)
			if slices.Contains(port.SecurityGroups, sg) {
			   ^
pkg/openstack/loadbalancer_sg.go:135:6: SA1019: slices.Contains is deprecated: use stdlib slices.Contains instead. (staticcheck)
		if slices.Contains(port.Tags, sg) {
		   ^

I'm confused why those are firing..

It's because we bumped k8s.io/utils also (which appear to have deprecated that lib). I've fixed this now.

@kayrus
Copy link
Contributor

kayrus commented Jan 23, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2026
@kayrus
Copy link
Contributor

kayrus commented Jan 23, 2026

/retest-required

@k8s-ci-robot
Copy link
Contributor

@stephenfin: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
openstack-cloud-controller-manager-e2e-test ce0bc8c link true /test openstack-cloud-controller-manager-e2e-test
openstack-cloud-controller-manager-ovn-e2e-test ce0bc8c link true /test openstack-cloud-controller-manager-ovn-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants