Skip to content

Conversation

@cwrau
Copy link
Contributor

@cwrau cwrau commented Jan 23, 2026

What this PR does / why we need it:

This allows the user to deploy the controller-manager split between the
management cluster and the workload cluster.

That way the cluster is not dependent "on itself".

Special notes for reviewers:

The management mode only deploys the controller and the workload mode only
deploys the necessary RBAC roles and bindings.

Release note:

[openstack-cloud-controller-manager] Allow deploying the controller-manager split between management and workload clusters.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 23, 2026
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from dulek and kayrus January 23, 2026 13:37
@k8s-ci-robot
Copy link
Contributor

Hi @cwrau. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 23, 2026
@cwrau cwrau force-pushed the feat/openstack-cloud-controller-manager/add-split-mode branch from caf6e28 to 5634d94 Compare January 23, 2026 13:41
@cwrau
Copy link
Contributor Author

cwrau commented Jan 23, 2026

This has shown itself to be useful when theres trouble with the nodes resulting in dozens or hundreds of NotReady nodes which in turn break other stuff like cilium, as their pods get scheduled there and will never run.

And the ccm can't clean those nodes up, as it doesn't run yet.

With this one can run the ccm outside the cluster which makes sure that it always works™️

@cwrau cwrau marked this pull request as draft January 23, 2026 13:45
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2026
@cwrau cwrau force-pushed the feat/openstack-cloud-controller-manager/add-split-mode branch from 5634d94 to d39bec4 Compare January 23, 2026 15:36
@cwrau cwrau marked this pull request as ready for review January 23, 2026 15:37
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2026
@cwrau cwrau force-pushed the feat/openstack-cloud-controller-manager/add-split-mode branch 3 times, most recently from 27e9653 to 3bec71b Compare January 23, 2026 16:25
This allows the user to deploy the controller-manager split between the
management cluster and the workload cluster.
@cwrau cwrau force-pushed the feat/openstack-cloud-controller-manager/add-split-mode branch from 3bec71b to a67f3fb Compare January 23, 2026 16:52
@cwrau
Copy link
Contributor Author

cwrau commented Jan 23, 2026

Ok, I thought I had to bump the chart version as I had to for #3067, but that also didn't help and I don't know how I would fix that dependency issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants