-
Notifications
You must be signed in to change notification settings - Fork 654
feat(openstack-cloud-controller-manager): add splitMode #3063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(openstack-cloud-controller-manager): add splitMode #3063
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @cwrau. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
caf6e28 to
5634d94
Compare
|
This has shown itself to be useful when theres trouble with the nodes resulting in dozens or hundreds of And the ccm can't clean those nodes up, as it doesn't run yet. With this one can run the ccm outside the cluster which makes sure that it always works™️ |
5634d94 to
d39bec4
Compare
27e9653 to
3bec71b
Compare
This allows the user to deploy the controller-manager split between the management cluster and the workload cluster.
3bec71b to
a67f3fb
Compare
|
Ok, I thought I had to bump the chart version as I had to for #3067, but that also didn't help and I don't know how I would fix that dependency issue |
What this PR does / why we need it:
This allows the user to deploy the controller-manager split between the
management cluster and the workload cluster.
That way the cluster is not dependent "on itself".
Special notes for reviewers:
The management mode only deploys the controller and the workload mode only
deploys the necessary RBAC roles and bindings.
Release note: