feat(openstack-cloud-controller-manager): add option to change deployment type

[cwrau]

What this PR does / why we need it:

This PR allows the user to choose between DaemonSet and Deployment.

Release note:

feat(openstack-cloud-controller-manager): allow user to choose between DaemonSet and Deployment

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @cwrau. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kayrus]

@cwrau thanks for the PR. Could you please describe your use case for the daemonset deployment style? I'd set the default style to be a deployment unless daemonset is set. Also please fix chart issues found by lint.

[cwrau]

@cwrau thanks for the PR. Could you please describe your use case for the daemonset deployment style? I'd set the default style to be a deployment unless daemonset is set. Also please fix chart issues found by lint.

I just wanted to keep the existing concept, so users don't have to do anything to keep the current setup.

I can set the default to deployment, but I imagine that that would kinda be a breaking change.

[kayrus]

@cwrau I never used helm-charts from this repo, and I just realized that it was always a DaemonSet, this is a surprise for me. All OCCM deployments that I worked with were always a Deployment. And I wonder what was the reason to be initially a DaemonSet.