CCM-MT Poc #935

priyapande · 2025-12-05T22:51:30Z

No description provided.

k8s-ci-robot · 2025-12-05T22:51:40Z

This issue is currently awaiting triage.

If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-12-05T22:51:41Z

Welcome @priyapande!

It looks like this is your first PR to kubernetes/cloud-provider-gcp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-gcp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-12-05T22:51:42Z

Hi @priyapande. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

aojea · 2025-12-06T22:25:02Z

pkg/apis/providerconfig/register.go

+package providerconfig
+
+var (
+	GroupName = "cloud.gke.io"


/hold

this should not be in this repo, see https://github.com/GoogleCloudPlatform/gke-networking-api per example

and then it can be consumed here from the external repo #725

bowei · 2025-12-08T17:53:08Z

/assign

… MultiNode Controller

k8s-ci-robot · 2025-12-10T00:04:39Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: priyapande
Once this PR has been reviewed and has the lgtm label, please ask for approval from bowei. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bowei · 2025-12-10T00:11:43Z

Can we split off the vendor change in a separate commit? Right now it's 300 files, but I'm assuming most of it is in vendor/

aojea · 2025-12-10T14:52:49Z

cmd/cloud-controller-manager/main.go

+			return startGkeMultiNodeControllerWrapper(initContext, completedConfig, cloud, nodeIpamController.nodeIPAMControllerOptions)
+		},
+	}
+	// app.ControllersDisabledByDefault.Insert(names.CloudNodeController)


this multiNodeControllerName has to be disabled by default , and better to have all things aggregated in Line 108-110 so we do not have risk of drifting the code by using these conventions

aojea · 2025-12-10T14:54:09Z

pkg/controller/nodemanager/cloud.go

+Copyright 2025 The Kubernetes Authors.
+*/
+
+package nodemanager


if this is gke only let's prefix the folder so we make it clear , pkg/controller/gkenodemanager or something

aojea · 2025-12-10T14:55:11Z

pkg/controller/nodemanager/cloud.go

+
+	"io"
+
+	"github.com/go-ini/ini"


is this dependency really needed?
let's try to avoid bringing cosmetic dependencies if possible

aojea · 2025-12-10T14:58:32Z

pkg/controller/nodemanager/filteredfactory.go

+// FilteredSharedInformerFactory wraps the standard factory.
+// It embeds the interface so all non-overridden methods (Start, WaitForCacheSync)
+// pass through to the underlying factory automatically.
+type FilteredSharedInformerFactory struct {


this has to be unexported if its planned to be used here, so or lowercase or under an /internal/ folder https://go.dev/doc/modules/layout#package-or-command-with-supporting-packages so it can not be consumed outside of this repo

aojea · 2025-12-10T14:58:52Z

pkg/controller/nodemanager/filteredinformer.go

+	"k8s.io/client-go/tools/cache"
+)
+
+type FilteredInformer struct {


ditto 3c0ad5f#r2607012378

aojea · 2025-12-10T15:01:25Z

pkg/controller/nodemanager/starter.go

+	klog.Infof("[%s] Creating OSS Cloud Node Controller...", pcKey)
+	nodeController, err := node.NewCloudNodeController(
+		filteredFactory.Core().V1().Nodes(),
+		m.kubeClient,
+		scopedCloud,
+		m.config.ComponentConfig.NodeStatusUpdateFrequency.Duration,
+		m.config.ComponentConfig.NodeController.ConcurrentNodeSyncs,
+	)
+	if err != nil {


there has to be two independent launchers, and users should opt-in via the standards flags to enable one or other controllers, check this for prior art https://github.com/kubernetes/cloud-provider-gcp/pull/895/files

The litmus test is that the addition of this new controller/folder will have zero impact, and the behavior is governed by the flags

aojea · 2025-12-10T15:02:51Z

cmd/cloud-controller-manager/main.go

+	controllerInitializers[multiNodeControllerName] = app.ControllerInitFuncConstructor{
+		InitContext: app.ControllerInitContext{
+			ClientName: multiNodeControllerClientName,
+		},
+		Constructor: func(initContext app.ControllerInitContext, completedConfig *cloudcontrollerconfig.CompletedConfig, cloud cloudprovider.Interface) app.InitFunc {
+			return startGkeMultiNodeControllerWrapper(initContext, completedConfig, cloud, nodeIpamController.nodeIPAMControllerOptions)
+		},
+	}


commented in 3c0ad5f#r2607023536 , this can be added as an opt-in new controller, that runs independently of the other controller, so users can use the flags to enable or disable one or other controller ...

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 5, 2025

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2025

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 5, 2025

k8s-ci-robot requested review from bridgetkromhout and cici37 December 5, 2025 22:51

k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 5, 2025

aojea reviewed Dec 6, 2025

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2025

k8s-ci-robot assigned bowei Dec 8, 2025

priyapande added 2 commits December 9, 2025 23:59

feat: Add FilteredInformers, Cloud, Starter, and Main changes for GKE…

3c0ad5f

… MultiNode Controller

feat: Implement Node Manager Controller, APIs, and update Vendor

fe0b6b9

priyapande force-pushed the ccm-poc branch from 12b46be to fe0b6b9 Compare December 10, 2025 00:04

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2025

aojea reviewed Dec 10, 2025

View reviewed changes

CCM-MT Poc #935

Are you sure you want to change the base?

CCM-MT Poc #935

Conversation

priyapande commented Dec 5, 2025

Uh oh!

k8s-ci-robot commented Dec 5, 2025

Uh oh!

k8s-ci-robot commented Dec 5, 2025

Uh oh!

k8s-ci-robot commented Dec 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bowei commented Dec 8, 2025

Uh oh!

k8s-ci-robot commented Dec 10, 2025

Uh oh!

bowei commented Dec 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants