Skip to content

Conversation

@adrianmoisey
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

In preparation of 1.35 being released

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/needs-area labels Dec 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianmoisey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2025
@k8s-ci-robot k8s-ci-robot added area/vertical-pod-autoscaler size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-area labels Dec 8, 2025
@adrianmoisey
Copy link
Member Author

(I'm not sure if we actually want to merge this, I just want to see what it looks like and if tests pass)

Copy link
Member

@omerap12 omerap12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, updating dependencies to an rc version isn’t ideal. We should wait for the full 1.35 release and update the dependencies afterward if needed.

@adrianmoisey
Copy link
Member Author

IMO, updating dependencies to an rc version isn’t ideal. We should wait for the full 1.35 release and update the dependencies afterward if needed.

Yeah, I figured I'd make something now, see what fails, and make smaller PRs to get ready (like remove use of deprecated functions)

@k8s-ci-robot
Copy link
Contributor

@adrianmoisey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-autoscaling-e2e-vpa-updater 35a45c9 link true /test pull-autoscaling-e2e-vpa-updater
pull-autoscaling-e2e-vpa-admission-controller 35a45c9 link true /test pull-autoscaling-e2e-vpa-admission-controller
pull-autoscaling-e2e-vpa-recommender 35a45c9 link true /test pull-autoscaling-e2e-vpa-recommender
pull-autoscaling-e2e-vpa-actuation 35a45c9 link true /test pull-autoscaling-e2e-vpa-actuation
pull-autoscaling-e2e-vpa-full 35a45c9 link true /test pull-autoscaling-e2e-vpa-full

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants