Skip to content

chore: add issue templates#262

Draft
vitorfloriano wants to merge 1 commit into
kubernetes-sigs:mainfrom
vitorfloriano:chore-add-github-issue-templates
Draft

chore: add issue templates#262
vitorfloriano wants to merge 1 commit into
kubernetes-sigs:mainfrom
vitorfloriano:chore-add-github-issue-templates

Conversation

@vitorfloriano
Copy link
Copy Markdown
Contributor

This PR adds Issue Templates to the repository.

We're adding templates (technically, they are forms) for bug report, feature request and issue tracking.

We're also allowing blank issues as an escape hatch, just in case.

For a preview of the templates, see: https://github.com/vitorfloriano/node-readiness-controller/tree/chore-add-github-issue-templates/.github/ISSUE_TEMPLATE

Follow-up to #227 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 19, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@netlify
Copy link
Copy Markdown

netlify Bot commented May 19, 2026

Deploy Preview for node-readiness-controller canceled.

Name Link
🔨 Latest commit c4f71e7
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/6a0bd77865a22f00081afc93

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vitorfloriano
Once this PR has been reviewed and has the lgtm label, please assign ajaysundark for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from tallclair May 19, 2026 03:22
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 19, 2026
@vitorfloriano
Copy link
Copy Markdown
Contributor Author

/cc @Priyankasaggu11929

I had copilot make the initial draft of the templates for me. I still need to refine them to remove any nonsense.

Just a couple of things:

  1. Should we go for markdown (templates) for more flexibility or yaml (forms) for more structure? I've noticed projects in the org use both. See: https://github.com/search?q=%28org%3Akubernetes+OR+org%3Akubernetes-sigs%29+path%3AISSUE_TEMPLATE+&type=code&p=2
  2. Should we enforce the templates/forms or should we still allow blank issues?
  3. I added links to direct users to Discussions, Slack and Security in the Issue creation modal. Should we keep those?

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2026
@Priyankasaggu11929
Copy link
Copy Markdown
Member

Should we go for markdown (templates) for more flexibility or yaml (forms) for more structure? I've noticed projects in the org use both. See: https://github.com/search?q=%28org%3Akubernetes+OR+org%3Akubernetes-sigs%29+path%3AISSUE_TEMPLATE+&type=code&p=2

I usually prefer Markdown templates (well, because they're simple) but looking at recent influx of gh issues contributions, I feel the pointed sections in yaml will encourage people to fill in proper information.

can we please add a line saying something like (not as it is, but you get the point) -

please describe the issue in a simple manner in your own language (and not with AI generated blurb)?

Should we enforce the templates/forms or should we still allow blank issues?

allow blank issues as well.


3. I added links to direct users to Discussions, Slack and Security in the Issue creation modal. Should we keep those?

I am not aware of it ^. How does this work? Could you please share an example?

Thank you!

@sahitya-chandra
Copy link
Copy Markdown
Contributor

Small suggestion on bug_report.yml: for the logs textarea, would you consider render: shell (or render: console) instead of render: text?

GitHub will render it as a syntax-highlighted code block, which keeps long controller log dumps from blowing out the issue layout.

@vitorfloriano
Copy link
Copy Markdown
Contributor Author

I am not aware of it ^. How does this work? Could you please share an example?

I merged this branch in my fork to preview the changes, so you can head over there and create a new issue. The Create a new issue modal will show links for Slack and Discussions:

https://github.com/vitorfloriano/node-readiness-controller/issues

The "Report a vulnerability" is duplicated because I wasn't aware that it was already there by default (though I'm not sure if that's only in my fork's config). I will remove that.

@Priyankasaggu11929
Copy link
Copy Markdown
Member

I merged this branch in my fork to preview the changes, so you can head over there and create a new issue. The Create a new issue modal will show links for Slack and Discussions:

Nice! TIL. Thank you and yes, let's add it.

image

The "Report a vulnerability" is duplicated because I wasn't aware that it was already there by default (though I'm not sure if that's only in my fork's config). I will remove that.

👍

@vitorfloriano
Copy link
Copy Markdown
Contributor Author

GitHub will render it as a syntax-highlighted code block, which keeps long controller log dumps from blowing out the issue layout.

@sahitya-chandra I tested render: shell, render: console and render: text and it seems that the log dumps will always be the same size, with minimal syntax highlighting.

Perhaps we should make a textarea with a <details> element in it. See the three Log sections in the issue I created to test this: vitorfloriano#7 (The last one is collapsible because I added a details element to the text area)

Or we could make it an upload form and have users send their logs in .txt.

Anyway, this is very bikesheddable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants