cleanup: remove dead cleanupNodesAfterSelectorChange code path

[dorodb-web22]

Summary

Removes the unreachable cleanupNodesAfterSelectorChange code path and all associated helpers that became dead code after nodeSelector was made immutable.

Background

NodeReadinessRule.spec.nodeSelector is immutable (enforced by the webhook since PR #164). Because the selector can never change after creation, the following code paths can never be triggered:

• The conditional block in Reconcile that detects selector changes and invokes the cleanup
• getCachedRule — only used by that block
• cleanupNodesAfterSelectorChange : the cleanup function itself
• nodeSelectorChanged in helper.go : the comparison helper

This was noted as a cleanup opportunity in issue #245.

Changes

• internal/controller/nodereadinessrule_controller.go
  • Removed the selector-change detection block from Reconcile
  • Deleted getCachedRule
  • Deleted cleanupNodesAfterSelectorChange
• internal/controller/helper.go
  • Deleted nodeSelectorChanged
  • Removed now-unused fmt and metav1 imports

Testing

go build ./... passes cleanly with no unused import errors.

Closes #245

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dorodb-web22
Once this PR has been reviewed and has the lgtm label, please assign sergeykanzhelev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @dorodb-web22. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for node-readiness-controller canceled.

Name	Link
🔨 Latest commit	9f3a66e
🔍 Latest deploy log	https://app.netlify.com/projects/node-readiness-controller/deploys/6a05326263ad290008665672

[Priyankasaggu11929]

/ok-to-test

Thanks for the PR @dorodb-web22.

Changes wrt unreachable code are fine. Just one non-blocking suggestion:

we have an integration test that checks for the immutability of the nodeSelector field -

node-readiness-controller/internal/controller/nodereadinessrule_controller_test.go

Lines 1475 to 1484 in b4a52fa

	It("should reject attempts to change the nodeSelector (immutable)", func() {
	updatedRule := &nodereadinessiov1alpha1.NodeReadinessRule{}
	Expect(k8sClient.Get(ctx, types.NamespacedName{Name: "selector-change-rule"}, updatedRule)).To(Succeed())
	updatedRule.Spec.NodeSelector = metav1.LabelSelector{
	MatchLabels: map[string]string{"env": "dev"},
	}
	err := k8sClient.Update(ctx, updatedRule)
	Expect(err).To(HaveOccurred())
	Expect(err.Error()).To(ContainSubstring("nodeSelector is immutable"))
	})

Could you add a ginkgo By() step annotation in the ^ test - so we actually print the CEL X-validation rejection error by API server, in our test logs.

(I was running these tests locally, and realized they pass silently even in verbose mode.)