Skip to content

Remove use of deprecated urllib3 functionality #2497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stephenfin wants to merge 3 commits into from
Closed

Remove use of deprecated urllib3 functionality #2497

stephenfin wants to merge 3 commits into from

Conversation

@stephenfin
Copy link

@stephenfin stephenfin commented Jan 8, 2026

What type of PR is this?

/kind feature

What this PR does / why we need it:

Remove use of deprecated urllib3 functionality. As noted in the commit message, this functionality was briefly removed in 2.6.0 but later re-added in 2.6.1. Ultimately, we should fix this by bumping the codegenerator version used here but that's a much larger change that should be tackled separately.

/assign @yliaog

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

This is an alternative to #2479.

Does this PR introduce a user-facing change?

NONE

(Technically we've deprecated a method but we won't remove this).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@stephenfin
Revert "commented out rest_urllib_headers.diff as it caused Attribute…
01783c4 
…Error:"

This reverts commit f9c38c5.
@stephenfin
Revert "Provides a patch to stop using urllib3 deprecated APIs until …
f79b97b 
…the upgrade to latest OpenAPI Generator (>6.4.0)"

This reverts commit 647d5d1. This was
patching the wrong thing.
@stephenfin
Remove use of deprecated urllib features
4129e36 
The Response.getheaders() and Response.getheader() methods were deprecated
in urllib3 2.0. They were briefly removed in 2.6.0 [1] before being
re-added in 2.6.1 [2], but they will eventually be removed entirely.
Carry a patch to address this until the generator is updated
accordingly.

[1] https://urllib3.readthedocs.io/en/stable/changelog.html#id4
[2] https://urllib3.readthedocs.io/en/stable/changelog.html#id3

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 8, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 8, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stephenfin
Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 8, 2026
This was referenced Jan 8, 2026
Open
Open
@stephenfin
Copy link
Author

stephenfin commented Jan 9, 2026

/close

I think we'd be better off working bumping the openapi-generator version than layering on even more patches to this. #2498 is a move in this direction at least.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 9, 2026

@stephenfin: Closed this PR.

Details

In response to this:

/close

I think we'd be better off working bumping the openapi-generator version than layering on even more patches to this. #2498 is a move in this direction at least.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@yliaog yliaog

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephenfin @k8s-ci-robot @yliaog