Add optional websocket keepalive pings for idle Exec sessions#2878
Draft
Copilot wants to merge 3 commits into
Draft
Add optional websocket keepalive pings for idle Exec sessions#2878Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Copilot
AI
changed the title
[WIP] Implement optional ping-pong for exec timeout
Add optional websocket keepalive pings for idle Exec sessions
May 26, 2026
mstruebing
reviewed
May 27, 2026
Member
mstruebing
left a comment
There was a problem hiding this comment.
/lgtm
Will leave it in this state for now. to give others the chance to look at it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exec websocket sessions can be dropped around the 5-minute mark in some proxy/network paths when no traffic is sent. This change adds an opt-in keepalive mechanism for
Execwithout changing default behavior.API: opt-in exec keepalive
ExecOptionswithpingIntervalMs?: number.Exec.exec(...)with an optional trailingoptionsparameter.Behavior: periodic websocket ping
pingIntervalMsis a positive integer,Execsends websocket ping frames on that interval while the socket is open.ping().Lifecycle: cleanup on termination
closeanderrorto avoid orphaned intervals.Coverage: focused unit test
exec_testcase validating that pings are emitted when configured and stop after close.