Reduce WebSocket flush wait from 100ms to 1ms #4461
Draft
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WebSocketOutputStream.flush()method was blocking for 100ms per iteration while waiting for the queue to drain, creating a throughput bottleneck for streaming operations likeExec.exec().Changes
FLUSH_WAIT_MILLIS(1ms) andMAX_FLUSH_ITERATIONS(10000) to replace magic numbersBefore:
After:
This provides up to 100× faster flush behavior while preserving the same maximum wait time.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.