Conversation
Dockerfile
Outdated
| EXPOSE 4000 | ||
| # Note --incremental mode is ineffective on the Mac owing to https://github.com/containers/podman/issues/22343. Use force_regenerate.sh to trigger the incremental reload after changing the file on the host. | ||
| CMD [ "bash", "-c", "eval \"$(rbenv init -)\" && cp -r /css/_sass/bootstrap /site/_sass/ && bundle exec jekyll serve --host ${JEKYLL_SERVE_BIND} --incremental --disable-disk-cache --destination /tmp/site"] | ||
| CMD [ "bash", "-c", "eval \"$(rbenv init -)\" && cp -r /css/_sass/bootstrap /site/_sass/ && bundle exec jekyll serve --future --host ${JEKYLL_SERVE_BIND} --incremental --disable-disk-cache --destination /tmp/site"] |
There was a problem hiding this comment.
this makes the future dated blog render with run.sh and run-snapshot.sh. Not sure if it's a good idea or not with no warning to the developer that their post won't render in reality. Though the status quo of a missing post could also cost new developers time and head-scratching.
Would be more comfy if #232 was added to warn us
There was a problem hiding this comment.
#232 is just waiting for an approval I can merge it at anytime.
Wonder if we could inject it as a build arg only from run-snapshot?
SamBarker
left a comment
SamBarker
left a comment
There was a problem hiding this comment.
Looking good @robobario a few thoughts to work on, but mostly there.
Dockerfile
Outdated
| EXPOSE 4000 | ||
| # Note --incremental mode is ineffective on the Mac owing to https://github.com/containers/podman/issues/22343. Use force_regenerate.sh to trigger the incremental reload after changing the file on the host. | ||
| CMD [ "bash", "-c", "eval \"$(rbenv init -)\" && cp -r /css/_sass/bootstrap /site/_sass/ && bundle exec jekyll serve --host ${JEKYLL_SERVE_BIND} --incremental --disable-disk-cache --destination /tmp/site"] | ||
| CMD [ "bash", "-c", "eval \"$(rbenv init -)\" && cp -r /css/_sass/bootstrap /site/_sass/ && bundle exec jekyll serve --future --host ${JEKYLL_SERVE_BIND} --incremental --disable-disk-cache --destination /tmp/site"] |
There was a problem hiding this comment.
#232 is just waiting for an approval I can merge it at anytime.
Wonder if we could inject it as a build arg only from run-snapshot?
robobario
force-pushed
the
020-blog
branch
2 times, most recently
from
4b59d86 to
0ddc1e7
Compare
SamBarker
left a comment
SamBarker
left a comment
There was a problem hiding this comment.
a couple of nits but LGTM.
Thanks for running this one @robobario
_posts/2026-04-01-release-0_20_0.md
Outdated
|
|
||
| ### Javadocs on the Website | ||
|
|
||
| Public API Javadocs are now published alongside version-specific documentation on [kroxylicious.io](https://kroxylicious.io), making it easier to explore our APIs without leaving your browser. |
There was a problem hiding this comment.
would be nice to link to the 0.20.0 javadoc here.
_posts/2026-04-01-release-0_20_0.md
Outdated
| | Proxy | [quay.io/kroxylicious/kroxylicious:0.20.0](https://quay.io/repository/kroxylicious/kroxylicious?tab=tags) (`sha256:6f9189cea822d3a96f00d1696b3ffad9a410be0fa0fce46900141756c7c9ca66`)| | ||
| | Operator | [quay.io/kroxylicious/operator:0.20.0](https://quay.io/repository/kroxylicious/operator?tab=tags) (`sha256:f12189f8b056e317d3c595a2009b016d6439f9906247bf7693edd24bee33dc9f`)| |
There was a problem hiding this comment.
I thought we would link directly to the image rather than the tags tab? Not sure what we did for 0.19.0 though?
There was a problem hiding this comment.
yeah this is a straight copy of the last blog. this is sort of duplicating the stuff on the download page, maybe we should link directly there instead of listing image details here
Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Robert Young <robertyoungnz@gmail.com>
Signed-off-by: Robert Young <robertyoungnz@gmail.com>
Co-authored-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Robert Young <robertyoungnz@gmail.com>
Co-authored-by: Sam Barker <sam@quadrocket.co.uk> Signed-off-by: Robert Young <robertyoungnz@gmail.com>
Signed-off-by: Robert Young <robertyoungnz@gmail.com>
Signed-off-by: Robert Young <robertyoungnz@gmail.com>
Signed-off-by: Robert Young <robertyoungnz@gmail.com>
Signed-off-by: Robert Young <robertyoungnz@gmail.com>
2 participants
No description provided.