Skip to content

update unkown09 opcode to treat last 2 bytes as story flag #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krogenth merged 1 commit into from
Jan 26, 2025
Merged

update unkown09 opcode to treat last 2 bytes as story flag #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/G2DataGUI.Common/Data/Maps/MapDialogueOpcodes/Unknown09Opcode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,15 @@ public class Unknown09Opcode : IMapDialogueOpcode
public DialogueOpcode Opcode { get; set; } = DialogueOpcode.Unknown09;
public byte Unknown1 { get; set; }
public byte Unknown2 { get; set; }
public byte Unknown3 { get; set; }
public byte Unknown4 { get; set; }
public short StoryFlag { get; set; }

public static IMapDialogueOpcode ReadOpcode(Stream reader)
{
return new Unknown09Opcode()
{
Unknown1 = reader.ReadRawByte(),
Unknown2 = reader.ReadRawByte(),
Unknown3 = reader.ReadRawByte(),
Unknown4 = reader.ReadRawByte(),
StoryFlag = reader.ReadRawShort(),
};
}
}
10 changes: 2 additions & 8 deletions src/G2DataGUI/UI/Views/Content/MapDialogue.axaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,6 @@
<ColumnDefinition Width="Auto" />
<ColumnDefinition Width="Auto" />
<ColumnDefinition Width="Auto" />
<ColumnDefinition Width="Auto" />
</Grid.ColumnDefinitions>
<StackPanel Grid.Column="0"
Margin="5,0">
Expand All @@ -702,13 +701,8 @@
</StackPanel>
<StackPanel Grid.Column="2"
Margin="5,0">
<TextBlock Text="Unknown #3:" />
<TextBox Text="{Binding Unknown3}" />
</StackPanel>
<StackPanel Grid.Column="3"
Margin="5,0">
<TextBlock Text="Unknown #4:" />
<TextBox Text="{Binding Unknown4}" />
<TextBlock Text="Story Flag:" />
<TextBox Text="{Binding StoryFlag}" />
</StackPanel>
</Grid>
</StackPanel>
Expand Down
Loading