Skip to content

refactor(asset): unify subclass fields via parameter properties #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krdlab merged 1 commit into from
May 9, 2026
Merged

refactor(asset): unify subclass fields via parameter properties #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,7 @@ class Asset {
// * NOTE https://github.com/HaxeFoundation/neko/releases/download/v2-4-0/neko-2.4.0-osx-universal.tar.gz
// * NOTE https://github.com/HaxeFoundation/neko/releases/download/v2-4-0/neko-2.4.0-win64.zip
class NekoAsset extends Asset {
nightly;
force32;
static resolveFromHaxeVersion(version, nightly) {
if (nightly) {
Expand All @@ -312,11 +313,10 @@ class NekoAsset extends Asset {
const force32 = version.startsWith('3.') && external_node_os_.platform() === 'win32';
return new NekoAsset(nekoVer, false, force32);
}
nightly = false;
constructor(version, nightly, force32) {
super('neko', version);
this.force32 = force32;
this.nightly = nightly;
this.force32 = force32;
}
get cachePlatform() {
return this.requireSupported(this.resolve('neko', this.force32)).cachePlatform;
Expand Down Expand Up @@ -347,7 +347,7 @@ class NekoAsset extends Asset {
// * NOTE https://github.com/HaxeFoundation/haxe/releases/download/3.4.7/haxe-3.4.7-win64.zip
// * NOTE https://build.haxe.org/builds/haxe/mac/haxe_latest.tar.gz
class HaxeAsset extends Asset {
nightly = false;
nightly;
constructor(version, nightly) {
super('haxe', version);
this.nightly = nightly;
Expand Down
13 changes: 5 additions & 8 deletions src/asset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,15 +330,12 @@ export class NekoAsset extends Asset {
return new NekoAsset(nekoVer, false, force32);
}

nightly = false;

constructor(
version: string,
nightly: boolean,
protected readonly nightly: boolean,
protected readonly force32: boolean,
) {
super('neko', version);
this.nightly = nightly;
}

get cachePlatform() {
Expand Down Expand Up @@ -377,11 +374,11 @@ export class NekoAsset extends Asset {
// * NOTE https://github.com/HaxeFoundation/haxe/releases/download/3.4.7/haxe-3.4.7-win64.zip
// * NOTE https://build.haxe.org/builds/haxe/mac/haxe_latest.tar.gz
export class HaxeAsset extends Asset {
nightly = false;

constructor(version: string, nightly: boolean) {
constructor(
version: string,
protected readonly nightly: boolean,
) {
super('haxe', version);
this.nightly = nightly;
}

get cachePlatform() {
Expand Down
Loading