Add v1alpha2 CLI e2e test suite#1006
Open
efiacor wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a parallel CLI end-to-end test suite that exercises the porchctl rpkg v1alpha2 dispatch path against v1alpha2 CRD-backed PackageRevision objects, using golden-file test cases and a dedicated make target.
Changes:
- Introduces a new v1alpha2 CLI e2e test entry point (
TestPorchV1Alpha2) that runs againsttestdata-v1alpha2/. - Adds 8 new golden-file CLI e2e scenarios under
test/e2e/cli/testdata-v1alpha2/. - Adds
make test-e2e-cli-v1alpha2to run only the v1alpha2 CLI e2e suite.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/cli/cli_e2e_v1alpha2_test.go | New v1alpha2 CLI e2e test entry point targeting testdata-v1alpha2/. |
| test/e2e/cli/testdata-v1alpha2/rpkg-clone/config.yaml | v1alpha2 golden test for rpkg clone flows. |
| test/e2e/cli/testdata-v1alpha2/rpkg-copy/config.yaml | v1alpha2 golden test for rpkg copy flow. |
| test/e2e/cli/testdata-v1alpha2/rpkg-get/config.yaml | v1alpha2 golden test for rpkg get and --show-kptfile behaviors. |
| test/e2e/cli/testdata-v1alpha2/rpkg-init/config.yaml | v1alpha2 golden test for rpkg init including duplicate-package error case. |
| test/e2e/cli/testdata-v1alpha2/rpkg-init-deploy/config.yaml | v1alpha2 golden test for deployment repos + rpkg init. |
| test/e2e/cli/testdata-v1alpha2/rpkg-lifecycle/config.yaml | v1alpha2 golden test for propose/approve/reject/delete lifecycle scenarios. |
| test/e2e/cli/testdata-v1alpha2/rpkg-push/config.yaml | v1alpha2 golden test for pull/edit/push workflow. |
| test/e2e/cli/testdata-v1alpha2/rpkg-upgrade/config.yaml | v1alpha2 golden test for upstream upgrade workflow. |
| make/testing.mk | Adds test-e2e-cli-v1alpha2 make target to run only the v1alpha2 suite. |
Add a standalone CLI e2e test suite for v1alpha2 in test/e2e/cli-v1alpha2/. Runs in complete isolation from the v1alpha1 CLI tests with its own CI job. Reuses the existing CliTestSuite framework from test/e2e/cli/ via import. Test cases exercise all v1alpha2-dispatched CLI commands end-to-end: - rpkg-init, rpkg-lifecycle, rpkg-get, rpkg-clone, rpkg-copy - rpkg-push, rpkg-upgrade, rpkg-init-deploy CI: added matrix entry 'Porch CLI E2E Tests (v1alpha2)' using run-in-kind-v1alpha2 deployment target. Makefile: added test-e2e-cli-v1alpha2 target. Golden file values are initial estimates; run with UPDATE_GOLDEN_FILES=1 against a live v1alpha2 cluster to capture actual output. Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
- Add waitForReady/waitForPublished config fields for async v1alpha2 ops - Add KubectlWaitForPackageRevisionReady with generation + PRR visibility checks - Add KubectlWaitForPackageRevisionPublished for revision number resolution - Add KubectlDeleteNamespaceV1Alpha2 with v1alpha2 finalizer removal - Add DeleteNamespaceFunc to CliTestSuite for v1alpha2 cleanup override - Strip uid from yaml normalizer (dynamic field like resourceVersion) - Update rpkg-clone, rpkg-copy, rpkg-init, rpkg-init-deploy, rpkg-push, rpkg-upgrade - Add rpkg-nested-package test case - Skip rpkg-get (revision/latest display gaps), rpkg-lifecycle (webhook gap), rpkg-push-on-render-failure, rpkg-unready (server-side render semantics) Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
Signed-off-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
✅ Deploy Preview for kpt-porch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Add v1alpha2 CLI e2e test suite
Description
TestPorchV1Alpha2), 8 golden-file test cases undertestdata-v1alpha2/, and amake test-e2e-cli-v1alpha2target.CliTestSuiteframework unchanged. A separatetestdata-v1alpha2/directory holds test cases that pass--api-version=v1alpha2to allrpkgcommands and--v1alpha2torepo register. When v1alpha1 is dropped, deletetestdata/+cli_e2e_test.goand renametestdata-v1alpha2/→testdata/.Related Issue(s)
Type of Change
Checklist
Testing Instructions (Optional)
make run-in-kind-v1alpha2to deploy porch with v1alpha2 CRD supportUPDATE_GOLDEN_FILES=1 E2E=1 go test -v -failfast -run TestPorchV1Alpha2 ./test/e2e/clito capture actual golden outputUPDATE_GOLDEN_FILESto verify tests passAdditional Notes (Optional)
UPDATE_GOLDEN_FILES=1is required to capture actual output (UIDs, timestamps, exact error strings).rpkg-nested-packageandrpkg-unreadytest cases once confirmed applicable to v1alpha2.push/pullcommands pass--api-version=v1alpha2for UX consistency even though it's currently a no-op (PRR stays at v1alpha1).AI Disclosure
If so, please describe how: