Align kpt version output format with porchctl#4545
Conversation
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the kpt version command to display both a version string and the Git commit hash (with dirty state) obtained from Go's embedded build info, and changes the Makefile to inject a date-based development version instead of a Git short hash.
Changes:
- Replaces single-line version output with multi-line output including version and VCS commit hash/dirty flag via
runtime/debug.ReadBuildInfo. - Changes Makefile
versionldflag value fromgit rev-parse --short HEADto a date-stamped development string. - Updates copyright year range.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| run/run.go | Extends version command to print version plus VCS commit hash and dirty status from build info. |
| Makefile | Replaces GIT_COMMIT with date-based KPT_VERSION used in ldflags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Would it be a hassle to add a |
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
46eef3a to
9486cfb
Compare
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
9486cfb to
f7e458c
Compare
Added --short option. |
Updates kpt version to display version information in the same two-line format as porchctl version, using debug.ReadBuildInfo() for git commit details.
It follows the same format/code as
porchctl.Before:
After:
For local builds:
AI usage disclosure