Skip to content

Bump gitlab.com/gitlab-org/api/client-go from 0.127.0 to 1.46.0#686

Closed
dependabot[bot] wants to merge 3 commits intomainfrom
dependabot/go_modules/gitlab.com/gitlab-org/api/client-go-1.46.0
Closed

Bump gitlab.com/gitlab-org/api/client-go from 0.127.0 to 1.46.0#686
dependabot[bot] wants to merge 3 commits intomainfrom
dependabot/go_modules/gitlab.com/gitlab-org/api/client-go-1.46.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Mar 6, 2026

Bumps gitlab.com/gitlab-org/api/client-go from 0.127.0 to 1.46.0.

Release notes

Sourced from gitlab.com/gitlab-org/api/client-go's releases.

v1.46.0

1.46.0

🚀 Features

1.46.0 (2026-03-01)

v1.45.0

1.45.0

🚀 Features

🔄 Other Changes

1.45.0 (2026-02-27)

Bug Fixes

  • test: Use epic IID instead of ID in DeleteEpic cleanup. (49dea05)

v1.44.0

1.44.0

🚀 Features

  • Implement runner controller instance-level runner scope support (!2765) by Timo Furrer

🔄 Other Changes

1.44.0 (2026-02-26)

v1.43.0

1.43.0

🚀 Features

... (truncated)

Changelog

Sourced from gitlab.com/gitlab-org/api/client-go's changelog.

1.46.0

🚀 Features

1.46.0 (2026-03-01)

1.45.0

🚀 Features

🔄 Other Changes

1.45.0 (2026-02-27)

Bug Fixes

  • test: Use epic IID instead of ID in DeleteEpic cleanup. (49dea05)

1.44.0

🚀 Features

  • Implement runner controller instance-level runner scope support (!2765) by Timo Furrer

🔄 Other Changes

1.44.0 (2026-02-26)

1.43.0

🚀 Features

... (truncated)

Commits
  • da7b8a7 chore(release): 1.46.0 [skip ci]
  • 072590b Merge branch 'Update_Urls_and_add-missing' into 'main'
  • 8b63461 Update urls and add missing
  • 0abd5ce chore(release): 1.45.0 [skip ci]
  • 6f5a6da Merge branch 'issue_#2237' into 'main'
  • 06094f9 Add LockMembershipsToSAML support to Application Settings
  • 37ff76b Merge branch 'fforster/epic-cleanup' into 'main'
  • 49dea05 fix(test): Use epic IID instead of ID in DeleteEpic cleanup.
  • 1e294d4 chore(release): 1.44.0 [skip ci]
  • 69b78fe Merge branch 'rc-runner-scopes' into 'main'
  • Additional commits viewable in compare view

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Mar 6, 2026
@sami-alajrami
Copy link
Copy Markdown
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/gitlab.com/gitlab-org/api/client-go-1.46.0 branch from cb5443d to 95fdd23 Compare March 17, 2026 13:18
@sami-alajrami
Copy link
Copy Markdown
Contributor

this is a major bump and requires some code change

@dependabot dependabot bot force-pushed the dependabot/go_modules/gitlab.com/gitlab-org/api/client-go-1.46.0 branch from 95fdd23 to 990a87d Compare March 18, 2026 13:18
@mbevc1
Copy link
Copy Markdown
Contributor

mbevc1 commented Mar 24, 2026

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/gitlab.com/gitlab-org/api/client-go-1.46.0 branch from 990a87d to 4c8ec35 Compare March 24, 2026 16:58
@claude
Copy link
Copy Markdown
Contributor

claude bot commented Mar 24, 2026

Claude finished @mbevc1's task in 1m 30s —— View job


PR Review: Bump gitlab.com/gitlab-org/api/client-go from 0.127.0 to 1.46.0

  • Run static analysis (build, vet, mod tidy)
  • Review changed files
  • Post review feedback

Static Analysis

All checks pass:

  • go build ./... — compiles cleanly
  • go vet ./... — no issues
  • go mod tidy — no diff (dependencies are clean)

Code Review

This is a major version bump (0.x → 1.x) of the GitLab API client library. The breaking change is that BasicMergeRequest.IID changed from int to int64, which required updating:

  1. internal/gitlab/gitlab.go:132GetMergeRequestApprovers(mrIID, version int64) signature updated from int to int64. The version parameter (an internal flag, always 1 or 2) was also changed to int64 since it shares the parameter type declaration. This is a minor cosmetic consequence but harmless.

  2. internal/gitlab/gitlab_test.go:235 — Test struct field mrIID int64 updated to match.

  3. go.mod / go.sum — Clean dependency update with a few transitive bumps (antlr, cel-go, go-querystring, godbus, wincred, retryablehttp, etc.) and one removal (stoewer/go-strcase).

Observations

  • The callers at lines 81, 103, and 163 of gitlab.go pass mr.IID directly from the BasicMergeRequest struct, so the type flows through correctly with no casts needed.
  • The GetMergeRequestCommits call at line 163 also takes mr.IID — this also compiles fine with the new int64 type.
  • No other files in the codebase reference GetMergeRequestApprovers or use the mrIID type directly, so there are no missed call sites.

Verdict

LGTM. The changes are minimal, correct, and well-scoped for this major version bump. The intint64 migration is the only breaking change and it's been handled properly in both production code and tests.

@mbevc1 mbevc1 enabled auto-merge (squash) March 24, 2026 17:02
@mbevc1
Copy link
Copy Markdown
Contributor

mbevc1 commented Mar 31, 2026

@dependabot rebase

Bumps [gitlab.com/gitlab-org/api/client-go](https://gitlab.com/gitlab-org/api/client-go) from 0.127.0 to 1.46.0.
- [Release notes](https://gitlab.com/gitlab-org/api/client-go/tags)
- [Changelog](https://gitlab.com/gitlab-org/api/client-go/blob/main/CHANGELOG.md)
- [Commits](https://gitlab.com/gitlab-org/api/client-go/compare/v0.127.0...v1.46.0)

---
updated-dependencies:
- dependency-name: gitlab.com/gitlab-org/api/client-go
  dependency-version: 1.46.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/gitlab.com/gitlab-org/api/client-go-1.46.0 branch from 4c8ec35 to 154318d Compare March 31, 2026 16:47
@mbevc1
Copy link
Copy Markdown
Contributor

mbevc1 commented Mar 31, 2026

@dependabot rebase

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot bot commented on behalf of github Mar 31, 2026

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@mbevc1 mbevc1 closed this Mar 31, 2026
auto-merge was automatically disabled March 31, 2026 17:12

Pull request was closed

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot bot commented on behalf of github Mar 31, 2026

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@mbevc1 mbevc1 reopened this Mar 31, 2026
@mbevc1 mbevc1 closed this Mar 31, 2026
@mbevc1 mbevc1 reopened this Mar 31, 2026
auto-merge was automatically disabled March 31, 2026 21:20

Pull request was closed

@dependabot dependabot bot deleted the dependabot/go_modules/gitlab.com/gitlab-org/api/client-go-1.46.0 branch March 31, 2026 21:20
@mbevc1 mbevc1 restored the dependabot/go_modules/gitlab.com/gitlab-org/api/client-go-1.46.0 branch March 31, 2026 21:20
@mbevc1 mbevc1 reopened this Mar 31, 2026
@mbevc1 mbevc1 closed this Mar 31, 2026
@dependabot dependabot bot deleted the dependabot/go_modules/gitlab.com/gitlab-org/api/client-go-1.46.0 branch March 31, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants