Skip to content

test: add playwright skill#1141

Merged
benoitf merged 5 commits intokortex-hub:mainfrom
serbangeorge-m:playwright-skill
Mar 20, 2026
Merged

test: add playwright skill#1141
benoitf merged 5 commits intokortex-hub:mainfrom
serbangeorge-m:playwright-skill

Conversation

@serbangeorge-m
Copy link
Contributor

Closes #1132

Signed-off-by: serbangeorge-m <serbangeorge.m@gmail.com>
@serbangeorge-m serbangeorge-m requested a review from a team as a code owner March 20, 2026 11:56
@serbangeorge-m serbangeorge-m requested review from benoitf and bmahabirbu and removed request for a team March 20, 2026 11:56
@coderabbitai
Copy link

coderabbitai bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1be50678-0407-4c94-bdd2-b8cb798ba64c

📥 Commits

Reviewing files that changed from the base of the PR and between 9579c97 and 9dd9415.

📒 Files selected for processing (1)
  • AGENTS.md
✅ Files skipped from review due to trivial changes (1)
  • AGENTS.md

📝 Walkthrough

Walkthrough

This PR introduces a comprehensive Playwright E2E testing skill documentation under .agents/skills/playwright-testing/, containing guides on test conventions, Page Object Model patterns, fixture setup, locator strategies, examples, and reference materials. It also updates AGENTS.md to reference this new documentation.

Changes

Cohort / File(s) Summary
Playwright Testing Skill Documentation
.agents/skills/playwright-testing/SKILL.md, .agents/skills/playwright-testing/examples.md, .agents/skills/playwright-testing/reference.md
Adds comprehensive Playwright E2E testing documentation covering POM structure, locator selection priorities (accessibility queries with fallbacks), fixture definitions, test execution patterns, base page abstractions, timeout constants, artifact capture, running/debugging commands, and 10 detailed testing examples.
AGENTS Reference
AGENTS.md
Appends reference to the new Playwright testing skill documentation under the E2E testing commands section.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'test: add playwright skill' directly and accurately summarizes the main change of adding Playwright E2E testing documentation and guidance to the repository.
Description check ✅ Passed The description references issue #1132, which aligns with the PR's purpose of adding a Playwright testing skill as documented in the linked issues.
Linked Issues check ✅ Passed The PR successfully implements the requirement from issue #1132 to introduce Playwright testing skill documentation, with comprehensive guides covering conventions, fixtures, locators, examples, and reference materials.
Out of Scope Changes check ✅ Passed All changes are directly related to adding Playwright testing skill documentation as specified in issue #1132, with only documentation files added (SKILL.md, examples.md, reference.md, and AGENTS.md update).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 markdownlint-cli2 (0.21.0)
AGENTS.md

markdownlint-cli2 v0.21.0 (markdownlint v0.40.0)
Finding: AGENTS.md
Linting: 1 file(s)
Summary: 0 error(s)
AggregateError: Unable to import module 'markdownlint-cli2-formatter-summarize'.
at importModule (file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2.mjs:81:11)
at async Promise.all (index 0)
at async outputResults (file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2.mjs:832:9)
at async main (file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2.mjs:1021:5)
at async file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2-bin.mjs:14:22 {
[errors]: [
Error: Cannot find module 'markdownlint-cli2-formatter-summarize'
Require stack:
- /usr/local/lib/node_modules/markdownlint-cli2/node_modules/markdownlint/lib/resolve-module.cjs
at Module._resolveFilename (node:internal/modules/cjs/loader:1369:15)
at resolve (node:internal/modules/helpers:145:19)
at resolveModu

... [truncated 1123 characters] ...

4:11)
at moduleResolve (node:internal/modules/esm/resolve:859:10)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at onImport.tracePromise.proto (node:internal/modules/esm/loader:659:36)
at TracingChannel.tracePromise (node:diagnostics_channel:344:14)
at ModuleLoader.import (node:internal/modules/esm/loader:658:21) {
code: 'ERR_MODULE_NOT_FOUND',
url: 'file:///markdownlint-cli2-formatter-summarize'
}
]
}


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.agents/skills/playwright-testing/examples.md:
- Around line 245-248: The example snippets use undefined/redeclared symbols:
declare or import a boolean isLinux (e.g., const isLinux = process.platform ===
'linux' or import from your test utils) before using it in the test skip; ensure
the locator this.detailsTabButton is defined on the page object (add a locator
property or replace with chatPage.locator('<selector>') so tests reference a
valid locator) and fix the duplicate const row by renaming or changing one to
let/assign in the outer scope (so the variable at 'row' on the later lines does
not redeclare the earlier one). Ensure these fixes are applied to the CHAT-07
snippet and the other occurrences referenced (symbols: isLinux,
this.detailsTabButton, const row).

In @.agents/skills/playwright-testing/reference.md:
- Around line 130-137: Update the project matrix in reference.md so it exactly
matches the behavior in tests/playwright/playwright.config.ts: add the
OpenShift-AI-Provider entry (same testMatch and resource naming used in the
config), change the Condition cells for Ollama-Provider and RamaLama-Provider to
indicate they are gated by runtime availability checks (not by OLLAMA_ENABLED or
RAMALAMA_ENABLED env vars), and verify the testMatch patterns and resource names
for all provider rows (Kortex-App-Core, Gemini-Provider, OpenAI-Provider,
Ollama-Provider, RamaLama-Provider, OpenShift-AI-Provider) mirror the values
used in playwright.config.ts (use the exact strings testMatch and resource names
from that file).

In @.agents/skills/playwright-testing/SKILL.md:
- Around line 150-153: Docs for the provider options are out-of-date: add
"openshift-ai" to the `resource` list and update the descriptions for
`resourceSetup`, `mcpSetup`, and `gooseSetup` to match Playwright's runtime
behavior—specifically note that Ollama and RamaLama are only checked/available
at runtime (not pre-configured) and that OpenShift requires a project to be
present but is not auto-enabled; ensure the same corrections are applied to the
duplicate block around lines 205-213 and reference the `resource`,
`resourceSetup`, `mcpSetup`, `gooseSetup`, Ollama, RamaLama, and openshift-ai
symbols so the text matches the implementation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a861e4e5-90bc-4cff-b9a4-d81aa91feaf7

📥 Commits

Reviewing files that changed from the base of the PR and between 625e35c and 0311b90.

📒 Files selected for processing (3)
  • .agents/skills/playwright-testing/SKILL.md
  • .agents/skills/playwright-testing/examples.md
  • .agents/skills/playwright-testing/reference.md

Signed-off-by: serbangeorge-m <serbangeorge.m@gmail.com>
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@benoitf
Copy link
Contributor

benoitf commented Mar 20, 2026

LGTM but I've opened #1142

as here it seems you were modifying CLAUDE.md file while it should be only a symlink to AGENTS.md

so you'll need to edit AGENTS.md file, not CLAUDE.md as part of this PR

serbangeorge-m and others added 3 commits March 20, 2026 13:59
Signed-off-by: serbangeorge-m <serbangeorge.m@gmail.com>
Signed-off-by: serbangeorge-m <serbangeorge.m@gmail.com>
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes for Agents.md (rather than Claude.md)

@benoitf benoitf merged commit a16a9bb into kortex-hub:main Mar 20, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add Playwright testing skill

2 participants