Skip to content

feat(registry): provide directory to runtimes #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feloy merged 1 commit into from
Mar 16, 2026
Merged

feat(registry): provide directory to runtimes #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkg/instances/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ import (
const (
// DefaultStorageFileName is the default filename for storing instances
DefaultStorageFileName = "instances.json"
// RuntimesSubdirectory is the subdirectory for runtime storage
RuntimesSubdirectory = "runtimes"
)

// InstanceFactory is a function that creates an Instance from InstanceData
Expand Down Expand Up @@ -70,7 +72,12 @@ var _ Manager = (*manager)(nil)

// NewManager creates a new instance manager with the given storage directory.
func NewManager(storageDir string) (Manager, error) {
return newManagerWithFactory(storageDir, NewInstanceFromData, generator.New(), runtime.NewRegistry())
runtimesDir := filepath.Join(storageDir, RuntimesSubdirectory)
reg, err := runtime.NewRegistry(runtimesDir)
if err != nil {
return nil, fmt.Errorf("failed to create runtime registry: %w", err)
}
return newManagerWithFactory(storageDir, NewInstanceFromData, generator.New(), reg)
}

// newManagerWithFactory creates a new instance manager with a custom instance factory, generator, and registry.
Expand Down
Loading
Loading