Fix view/edit to support multi-word PAGER/EDITOR#1
Merged
kooler merged 1 commit intokooler:mainfrom Apr 7, 2026
Merged
Conversation
Consolidate viewFileCmd and editFileCmd into a shared externalCmd helper that splits the env var with strings.Fields, so commands like EDITOR="code --wait" work correctly.
Owner
|
Thank you, good improvement! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
viewFileCmdandeditFileCmdto handle multi-word environment variables (e.g.EDITOR="code --wait") by splitting withstrings.FieldsexternalCmdhelperTest plan
EDITOR="vim"and verify edit worksEDITOR="code --wait"and verify edit works with multi-word commandPAGER="less -R"and verify view works with flagsEDITOR/PAGERand verify fallbacks (vi/less) workEDITOR=" "and verify fallback is used