fix: coverage accuracy, UI consistency, and dark theme icon fixes#5
Merged
fix: coverage accuracy, UI consistency, and dark theme icon fixes#5
Conversation
Incorporates all changes cleanly on top of main (after PR #2 relative-paths fix and PR #3 CI release automation): - Parse arc table for branch-coverage .coverage files (coverage.py branch=true) - inferMissingLines tracks bracket depth — no false reds on __all__, multi-line calls - Pytest auto-run via child_process.spawn — no ^C corruption from Python extension - Debounced file-watcher reloads, mutex on handleNoCoverage prompt - Consistent filtered % across status bar, tree Overall, and dashboard ring - displayPath (workspace-relative) preserved from PR #2 in both dashboard and tree - Empty-file filter from PR #2 combined with test-file filter (excludeTestFiles) - Dashboard tab ThemeIcon, header inline SVG — both themes correct - Coverage tree back in Explorer panel, Summary clickable to open dashboard - Removed info-message toast on every reload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #4 (closed due to merge conflicts — this branch is cleanly rebased on current main).
Problems fixed
1. Percentage mismatch across all surfaces
Status bar, tree "Overall", and dashboard ring were each computing totals differently — three different numbers. All three now apply identical filter logic: skip empty files (
executedLines + missingLines === 0) and respectexcludeTestFiles, producing consistent percentages everywhere.2. Dashboard tab icon invisible on dark themes
Panel tab now uses
ThemeIcon('graph')which VS Code themes automatically. Dashboard header icon is inlined SVG socurrentColorinherits the editor foreground on both light and dark.3. Coverage tree moved back to Explorer
Custom activity bar container was hard to discover. Tree view is back in Explorer where users naturally look.
4. Noisy info popup on every reload
Removed
showInformationMessagetoast that fired on every auto-reload. The status bar shows the same information persistently.What changed
src/extension.ts— filtered stats for status bar, removed info toastsrc/ui/statusBar.ts— accepts pre-computed filtered stats instead of raw reportsrc/ui/dashboardPanel.ts— ThemeIcon for panel tab, inline SVG header icon, filtered ring totals, workspace-relative display pathssrc/providers/treeProvider.ts— filtered Overall summary, test-file filter, display pathssrc/config.ts—excludeTestFilessettingpackage.json— tree back in Explorer,excludeTestFilesconfig entryassets/icon-dashboard.svg— new inline SVG icon usingcurrentColor