Add Support to Kool Cloud Deploy to ARM#524
Merged
fabriciojs merged 3 commits intomainfrom May 22, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for deploying to ARM platforms by updating the Docker build command and related configurations. Key changes include:
- Updating BuildPushImageForDeploy to accept a new 'platform' parameter for Docker.
- Adding a new Platform flag with a default value to the cloud deploy command.
- Including additional indirect dependencies in go.mod.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| services/cloud/build.go | Updated BuildPushImageForDeploy to use a platform parameter. |
| go.mod | Added new indirect dependencies. |
| commands/cloud_deploy.go | Added a Platform flag and updated the deploy command invocation. |
Comments suppressed due to low confidence (3)
services/cloud/build.go:18
- The updated function signature now requires a 'platform' parameter. Confirm that all function invocations have been updated accordingly.
func BuildPushImageForDeploy(service string, config *DeployConfigService, deploy *api.DeployCreateResponse, platform string) (err error) {
commands/cloud_deploy.go:56
- [nitpick] Ensure the default value 'linux/amd64' is documented in the usage instructions or README to inform users of the expected behavior.
cmd.Flags().StringVarP(&deploy.flags.Platform, "platform", "", "linux/amd64", "Platform for docker build (default: linux/amd64)")
go.mod:53
- [nitpick] Verify that the addition of this indirect dependency is required for the implementation of ARM support and is kept current.
github.com/russross/blackfriday/v2 v2.1.0 // indirect
| WwwRedirect bool // env: KOOL_DEPLOY_WWW_REDIRECT | ||
| DeployDomainExtras []string // env: KOOL_DEPLOY_DOMAIN_EXTRAS | ||
|
|
||
| Platform string // platform for docker build, e.g. linux/amd64 |
There was a problem hiding this comment.
[nitpick] Consider expanding the comment to document the range of acceptable platform values for clarity.
|
|
||
| require ( | ||
| github.com/Azure/go-ansiterm v0.0.0-20230124172434-306776ec8161 // indirect | ||
| github.com/cpuguy83/go-md2man/v2 v2.0.2 // indirect |
There was a problem hiding this comment.
[nitpick] Review whether this indirect dependency is necessary for the new ARM support to avoid unnecessary maintenance overhead.
Suggested change
| github.com/cpuguy83/go-md2man/v2 v2.0.2 // indirect |
fabriciojs
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.