Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/components/breadcrumbs/e2e.playwright-spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect, Locator, Page, test } from '@playwright/test';
import { e2eEnableDarkTheme, e2eWhenStable } from 'packages/e2e/utils';
import { e2eEnableDarkTheme } from 'packages/e2e/utils';

// @TODO: should be fixed (#DS-4622)
test.fixme('KbqBreadcrumbsModule', () => {
Expand All @@ -13,8 +13,6 @@ test.fixme('KbqBreadcrumbsModule', () => {

const component = getComponent(page);

await e2eWhenStable(component);

await expect(component).toHaveScreenshot('01-light.png');
await e2eEnableDarkTheme(page);
await expect(component).toHaveScreenshot('01-dark.png');
Expand All @@ -25,8 +23,6 @@ test.fixme('KbqBreadcrumbsModule', () => {

const component = getComponent(page);

await e2eWhenStable(component);

const screenshotTarget = getBreadcrumbsWithDropdown(component);

await getLastBreadcrumbItem(screenshotTarget).hover();
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified packages/components/button/__screenshots__/02-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified packages/components/icon/__screenshots__/01-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified packages/components/icon/__screenshots__/01-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions packages/components/popover/e2e.playwright-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ test.describe('KbqPopoverModule', () => {
await page.goto('/E2ePopoverStates');
const locator = getComponent(page);

await expect(getScreenshotTarget(locator)).toHaveScreenshot('01-light.png', { threshold: 0.05 });
await expect(getScreenshotTarget(locator)).toHaveScreenshot('01-light.png');
await e2eEnableDarkTheme(page);
await expect(getScreenshotTarget(locator)).toHaveScreenshot('01-dark.png', { threshold: 0.05 });
await expect(getScreenshotTarget(locator)).toHaveScreenshot('01-dark.png');
});
});
});
Binary file modified packages/components/tabs/__screenshots__/01-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified packages/components/tabs/__screenshots__/01-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 3 additions & 4 deletions packages/components/tabs/e2e.playwright-spec.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { expect, Page, test } from '@playwright/test';
import { e2eEnableDarkTheme, e2eWhenStable } from 'packages/e2e/utils';
import { e2eEnableDarkTheme } from 'packages/e2e/utils';

test.describe('KbqTabsModule', () => {
// @TODO: should be fixed (#DS-4627)
test.fixme('KbqTabsModule', () => {
test.describe('E2eTabsStates', () => {
const getComponent = (page: Page) => page.getByTestId('e2eTabsStates');

Expand All @@ -10,8 +11,6 @@ test.describe('KbqTabsModule', () => {

const component = getComponent(page);

await e2eWhenStable(component);

await expect(component).toHaveScreenshot('01-light.png');
await e2eEnableDarkTheme(page);
await expect(component).toHaveScreenshot('01-dark.png');
Expand Down
Binary file modified packages/components/toggle/__screenshots__/01-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified packages/components/toggle/__screenshots__/01-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified packages/components/toggle/__screenshots__/02-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions packages/components/tooltip/e2e.playwright-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ test.describe('KbqTooltipModule', () => {
await page.goto('/E2eTooltipStates');
const locator = getComponent(page);

await expect(getScreenshotTarget(locator)).toHaveScreenshot('01-light.png', { threshold: 0.05 });
await expect(getScreenshotTarget(locator)).toHaveScreenshot('01-light.png');
await e2eEnableDarkTheme(page);
await expect(getScreenshotTarget(locator)).toHaveScreenshot('01-dark.png', { threshold: 0.05 });
await expect(getScreenshotTarget(locator)).toHaveScreenshot('01-dark.png');
});
});
});
1 change: 0 additions & 1 deletion packages/e2e/utils/index.ts
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
export * from './theme';
export * from './when-stable';
17 changes: 0 additions & 17 deletions packages/e2e/utils/when-stable.ts

This file was deleted.

2 changes: 1 addition & 1 deletion playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default defineConfig({
expect: {
toHaveScreenshot: {
pathTemplate: '{testFileDir}/__screenshots__/{arg}{ext}',
threshold: 0.2,
threshold: 0,
scale: 'device',
animations: 'disabled'
}
Expand Down
Loading