Skip to content

fix(tooltip, popover): shadow for dark theme (#DS-4541) (#1286) #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lskramarov merged 1 commit into from
Jan 16, 2026
Merged

fix(tooltip, popover): shadow for dark theme (#DS-4541) (#1286) #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/components-dev/popover/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { KbqRadioModule } from '@koobiq/components/radio';
import { KbqSelectModule } from '@koobiq/components/select';
import { KbqSplitterModule } from '@koobiq/components/splitter';
import { PopoverExamplesModule } from 'packages/docs-examples/components/popover';
import { DevThemeToggle } from '../theme-toggle';

@Component({
standalone: true,
Expand Down Expand Up @@ -54,7 +55,8 @@ class DevExamples {}
KbqRadioModule,
KbqLinkModule,
DevExamples,
NgClass
NgClass,
DevThemeToggle
],
encapsulation: ViewEncapsulation.None,
changeDetection: ChangeDetectionStrategy.OnPush
Expand Down
2 changes: 2 additions & 0 deletions packages/components-dev/popover/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<dev-theme-toggle />

<ng-template #customContent>
@switch (popoverActiveStage) {
@case (1) {
Expand Down
4 changes: 3 additions & 1 deletion packages/components-dev/tooltip/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { KbqInputModule } from '@koobiq/components/input';
import { KbqSelectModule } from '@koobiq/components/select';
import { KbqToggleModule } from '@koobiq/components/toggle';
import { KbqToolTipModule } from '@koobiq/components/tooltip';
import { DevThemeToggle } from '../theme-toggle';

@Component({
standalone: true,
Expand All @@ -28,7 +29,8 @@ import { KbqToolTipModule } from '@koobiq/components/tooltip';
KbqSelectModule,
KbqIconModule,
KbqToggleModule,
NgClass
NgClass,
DevThemeToggle
],
selector: 'dev-app',
styleUrls: ['./styles.scss'],
Expand Down
2 changes: 2 additions & 0 deletions packages/components-dev/tooltip/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<dev-theme-toggle />

<ng-template #tooltipContent let-ctx>
<div>{{ ctx.content }}</div>
</ng-template>
Expand Down
4 changes: 2 additions & 2 deletions packages/components/popover/_popover-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

@mixin kbq-popover-theme() {
.kbq-popover {
box-shadow: var(--kbq-popover-borderless-shadow);
box-shadow: var(--kbq-popover-container-shadow);

&.kbq-popover_arrowless {
box-shadow: var(--kbq-popover-container-shadow);
Expand All @@ -14,7 +14,7 @@
}

.kbq-popover__arrow {
box-shadow: var(--kbq-popover-borderless-shadow);
box-shadow: var(--kbq-popover-container-shadow);
background: var(--kbq-popover-container-background);
}

Expand Down
11 changes: 5 additions & 6 deletions packages/components/tooltip/_tooltip-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

& .kbq-tooltip__arrow {
background-color: var(--kbq-tooltip-#{$style-name}-background);
box-shadow: var(--kbq-tooltip-borderless-shadow);
}

&.kbq-tooltip_arrowless {
Expand All @@ -18,11 +17,6 @@
}

@mixin kbq-tooltip-theme() {
.kbq-tooltip,
.kbq-tooltip__arrow {
box-shadow: var(--kbq-tooltip-borderless-shadow);
}

.kbq-tooltip.kbq-theme {
@include kbq-tooltip-color(theme-fade-off);
}
Expand All @@ -33,6 +27,11 @@

.kbq-tooltip.kbq-contrast-fade {
@include kbq-tooltip-color(contrast-fade-on);

&.kbq-tooltip,
& .kbq-tooltip__arrow {
box-shadow: var(--kbq-shadow-popup);
}
}

.kbq-tooltip.kbq-warning {
Expand Down