Skip to content

fix(checkbox): unnecessary padding (#DS-4564) #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
artembelik merged 4 commits into from
Jan 16, 2026
Merged

fix(checkbox): unnecessary padding (#DS-4564) #1276

artembelik merged 4 commits into from
Jan 16, 2026
+5 −21

Conversation

@artembelik
Copy link
Contributor

@artembelik artembelik commented Jan 15, 2026

No description provided.

@artembelik artembelik self-assigned this Jan 15, 2026
Copilot AI review requested due to automatic review settings January 15, 2026 07:32
Copilot AI reviewed Jan 15, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors checkbox padding calculations in SCSS by extracting repeated padding variable declarations to reduce code duplication. The fix addresses unnecessary padding calculations that were being defined multiple times across different checkbox style blocks.

Changes:

  • Extracted the normal-sized checkbox padding calculation to a file-level private variable
  • Moved the big checkbox padding variable declaration to be scoped within the kbq-checkbox_big selector
  • Consolidated all references to use the extracted variables instead of inline declarations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Jan 15, 2026 •
edited
Loading

Visit the preview URL for this PR (updated for commit 6119ecb):

https://koobiq-next--prs-1276-joir08f3.web.app

(expires Wed, 21 Jan 2026 09:01:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@artembelik artembelik added the bug Something isn't working label Jan 15, 2026
@github-actions
Copy link

github-actions bot commented Jan 15, 2026

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

@artembelik
Copy link
Contributor Author

artembelik commented Jan 15, 2026

/approve-snapshots

@github-actions
Copy link

github-actions bot commented Jan 15, 2026

🔄 Updating snapshots.

@github-actions
Copy link

github-actions bot commented Jan 15, 2026

✅ Snapshots updated!

@github-actions github-actions bot requested a review from lskramarov as a code owner January 15, 2026 07:46
@artembelik artembelik merged commit 3a753aa into main Jan 16, 2026
8 checks passed
@artembelik artembelik deleted the fix/DS-4564 branch January 16, 2026 11:51
@artembelik artembelik restored the fix/DS-4564 branch January 16, 2026 11:54
@artembelik artembelik deleted the fix/DS-4564 branch January 16, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@lskramarov lskramarov lskramarov approved these changes

@NikGurev NikGurev NikGurev approved these changes

Assignees

@artembelik artembelik

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@artembelik @lskramarov @NikGurev