chore(e2e): each test on separate page (#DS-4590) #1271
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the e2e test infrastructure to run each test component on a separate route/page rather than all components on a single page. This improves test isolation and enables better parallelization.
Changes:
- Introduced routing configuration for individual e2e components
- Updated template to use router-outlet with conditional dev-mode navigation
- Modified all test specifications to navigate to component-specific routes
- Added environment configuration and production build support
Reviewed changes
Copilot reviewed 65 out of 71 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| playwright.config.ts | Updated workers to 100% in CI and added production configuration to web server |
| packages/e2e/routes.ts | New file defining routes for all e2e components |
| packages/e2e/module.ts | Refactored to use router with minimal imports |
| packages/e2e/template.html | Replaced inline components with router-outlet and dev navigation |
| packages/e2e/main.ts | Added environment and routing integration |
| packages/e2e/utils/theme.ts | Updated dark theme toggle to use direct DOM manipulation |
| packages/e2e/utils/page.ts | Removed (e2eGoToRootPage no longer needed) |
| packages/e2e/environments/* | Added environment configuration files |
| packages/components/*/e2e.playwright-spec.ts | Updated all tests to navigate to specific routes |
| packages/components/timepicker/e2e.ts | Added KbqLuxonDateModule import |
| packages/components/filter-bar/e2e.ts | Added KbqLuxonDateModule import |
| packages/components/button-toggle/e2e.ts | Updated to use KbqButtonToggleModule |
| angular.json | Added build configurations for production and development |
| .stylelintrc.js | Added e2e-specific selector pattern rules |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Visit the preview URL for this PR (updated for commit 27b8a06): https://koobiq-next--prs-1271-oggn6e8d.web.app (expires Sun, 18 Jan 2026 14:13:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
artembelik
force-pushed
the
feat/DS-4590
branch
from
48b433e to
53b65da
Compare
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
artembelik
force-pushed
the
feat/DS-4590
branch
from
3ef908b to
342149a
Compare
artembelik
force-pushed
the
feat/DS-4590
branch
from
342149a to
6595bd0
Compare
🚨 E2E tests failedReview the report for details. 💡 Comment |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
🚨 E2E tests failedReview the report for details. 💡 Comment |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
No description provided.